Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert logs integration to type: input #5347

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Convert logs integration to type: input #5347

merged 5 commits into from
Apr 3, 2023

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Feb 21, 2023

Closes #5162

Move the custom logs integration to be an input package.

Input packages can only move to GA if they specify a kibana version greater than or equal to 8.8

I have removed the default value for dataset so that dataset is not hidden in the "advanced" tab, the UI does still default it to generic. This is because I believe dataset should be more prominent for an input package.

Test Scenarios

to test, use the elastic-package install command from the logs directory.

  • Upgrade an existing logs policy to the input package version
    • There should be no conflicts in the upgrade
    • Logs should not be re-ingested
    • Logs should continue to be ingested to the same index
    • no new index template should be created
  • Create a new logs policy
    • on policy creation the templates for the specified dataset should be created, e.g helloworld dataset should create logs-helloworld index template

Screenshot 2023-03-28 at 15 55 39

@hop-dev hop-dev self-assigned this Feb 21, 2023
@hop-dev hop-dev changed the title Convert logs integration to be type: input Convert logs integration to type: input Feb 21, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-28T15:14:37.026+0000

  • Duration: 15 min 43 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

- type: logfile
title: Custom log file
description: Collect your custom log files.
input: logfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I saw this PR and was wondering (and this could be the wrong place to ask this). But I believe that the logfile input is deprecated. With this PR introducing a major version increase and a minimum version of 8.8.0. Would it make sense to migrate this to the filestream input and leverage the new take_over functionality added in 8.7.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BenB196 sorry about the delay in replying.

I spoke to @rdner last week about this last week and his view was that as the takeover mode is still considered beta and it isn't ready for us to move the custom logs integration over just yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to release a beta package with the filestream+take_over first and let people to try it out.

@hop-dev hop-dev force-pushed the 5162-log-input-pkg branch from d8300e8 to 6a14810 Compare March 28, 2023 15:01
@hop-dev hop-dev marked this pull request as ready for review March 28, 2023 15:02
@hop-dev hop-dev requested a review from a team as a code owner March 28, 2023 15:02
@hop-dev
Copy link
Contributor Author

hop-dev commented Mar 31, 2023

OK this is ready to merge, I have re-run my tests. Going to wait until Monday morning though 😅

@hop-dev hop-dev merged commit f561e00 into main Apr 3, 2023
@hop-dev hop-dev deleted the 5162-log-input-pkg branch April 3, 2023 08:33
@elasticmachine
Copy link

Package log - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move custom_logs to type: input
4 participants