-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert logs integration to type: input
#5347
Conversation
type: input
type: input
- type: logfile | ||
title: Custom log file | ||
description: Collect your custom log files. | ||
input: logfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I saw this PR and was wondering (and this could be the wrong place to ask this). But I believe that the logfile
input is deprecated. With this PR introducing a major version increase and a minimum version of 8.8.0
. Would it make sense to migrate this to the filestream
input and leverage the new take_over
functionality added in 8.7.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to release a beta package with the filestream+take_over first and let people to try it out.
d8300e8
to
6a14810
Compare
OK this is ready to merge, I have re-run my tests. Going to wait until Monday morning though 😅 |
Package log - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=log |
Closes #5162
Move the custom logs integration to be an input package.
Input packages can only move to GA if they specify a kibana version greater than or equal to 8.8
I have removed the default value for dataset so that dataset is not hidden in the "advanced" tab, the UI does still default it to generic. This is because I believe dataset should be more prominent for an input package.
Test Scenarios
to test, use the
elastic-package install
command from the logs directory.