Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RabbitMQ] Add dimension fields to support TSDB enablement for exchange datastream. #5634

Merged

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Mar 22, 2023

  • Enhancement

What does this PR do?

This PR adds dimension fields for exchange datastream of rabbitmq for tsdb enablement.

Checklist

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-03T14:20:47.116+0000

  • Duration: 16 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 70.0% (14/20) 👎 -3.913
Lines 73.913% (34/46) 👍
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar mentioned this pull request Mar 22, 2023
21 tasks
@ritalwar ritalwar marked this pull request as ready for review March 22, 2023 12:21
@ritalwar ritalwar requested a review from a team as a code owner March 22, 2023 12:21
@agithomas agithomas changed the title Add dimension fields to support TSDB enablement for exchange datastream. [RabbitMQ] Add dimension fields to support TSDB enablement for exchange datastream. Mar 22, 2023
agithomas
agithomas previously approved these changes Mar 27, 2023
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agithomas agithomas dismissed their stale review March 27, 2023 06:32

Need to add additional dimension

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritalwar ritalwar merged commit 7d4790d into elastic:main Apr 3, 2023
@elasticmachine
Copy link

Package rabbitmq - 1.8.1 containing this change is available at https://epr.elastic.co/search?package=rabbitmq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants