-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP] Billing dashboard fixes #5665
Conversation
Export the dashboard with Stack 8.6.1 so that subsequent changes are easier to spot and review.
Total billing cost for a period is not reported daily but as a sum of all preceding periods. Thus using `sum` as the dashboard was doing was producing wrong result.
🌐 Coverage report
|
thanks edo! these dashboard changes are impossible to review - would it be possible to show screenshots for before and after, on the same dataset? thanks! |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Can we have someone review the code and release the fix please ? |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
👍 |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |
Hello @tommyers-elastic What's the status on this issue please ? Thank you |
Hi I see it as not fixed in 8.10.2 , latest GCP integration |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
:+1 |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi @endorama, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks! |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
What does this PR do?
last_value
for total billing cost instead of sum, as GCP data is already an aggregationevent.dataset: gcp.billing
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots