Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Billing dashboard fixes #5665

Closed
wants to merge 6 commits into from
Closed

[GCP] Billing dashboard fixes #5665

wants to merge 6 commits into from

Conversation

endorama
Copy link
Member

@endorama endorama commented Mar 23, 2023

What does this PR do?

  • update GCP Billing Overview dashboard to 8.6.0 format
  • use last_value for total billing cost instead of sum, as GCP data is already an aggregation
  • add filter for event.dataset: gcp.billing
  • replace filters with controls

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

image

Export the dashboard with Stack 8.6.1 so that subsequent changes are
easier to spot and review.
Total billing cost for a period is not reported daily but as a sum of
all preceding periods. Thus using `sum` as the dashboard was doing was
producing wrong result.
@endorama endorama marked this pull request as ready for review March 23, 2023 16:47
@endorama endorama requested review from a team as code owners March 23, 2023 16:47
@elasticmachine
Copy link

elasticmachine commented Mar 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-06T13:18:39.111+0000

  • Duration: 18 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 59
Skipped 0
Total 59

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 23, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 89.623% (95/106) 👍 6.644
Lines 96.0% (1464/1525) 👍 14.312
Conditionals 100.0% (0/0) 💚

@tommyers-elastic
Copy link
Contributor

thanks edo! these dashboard changes are impossible to review - would it be possible to show screenshots for before and after, on the same dataset? thanks!

@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Apr 4, 2023
@botelastic
Copy link

botelastic bot commented May 6, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 6, 2023
@Danouchka
Copy link

Can we have someone review the code and release the fix please ?
Thank you

@botelastic botelastic bot removed the Stalled label May 10, 2023
@botelastic
Copy link

botelastic bot commented Jun 9, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 9, 2023
@Danouchka
Copy link

👍

@botelastic botelastic bot removed the Stalled label Jun 9, 2023
@botelastic
Copy link

botelastic bot commented Jul 9, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 9, 2023
@botelastic
Copy link

botelastic bot commented Aug 8, 2023

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Aug 8, 2023
@Danouchka
Copy link

Hello @tommyers-elastic

What's the status on this issue please ?

Thank you

@Danouchka
Copy link

Hi I see it as not fixed in 8.10.2 , latest GCP integration

@Danouchka Danouchka reopened this Oct 3, 2023
@botelastic botelastic bot removed the Stalled label Oct 3, 2023
@botelastic
Copy link

botelastic bot commented Nov 2, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Nov 2, 2023
@Danouchka
Copy link

:+1

@botelastic
Copy link

botelastic bot commented Dec 2, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Dec 2, 2023
@mrodm
Copy link
Contributor

mrodm commented Dec 21, 2023

Hi @endorama, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@botelastic botelastic bot removed the Stalled label Dec 21, 2023
@botelastic
Copy link

botelastic bot commented Jan 20, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 20, 2024
@endorama endorama closed this by deleting the head repository Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:gcp Google Cloud Platform Stalled Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard [Metrics GCP] Billing Overview - wrong total billing cost per invoice month
5 participants