[Fleet] Remove host and port for Fleet Server

[nchaulet]

Description

Remove the host and port field from the Fleet server integration as it seems those values are only configurable during Fleet server installation.

Related to 154674

cc @jen-huang @michel-laterman

Should we restrict that package to newest version of Kibana (8.7?)

Tests

I tested manually:

• that a fleet server is available when not providing any port or host
• that you can customize fleet server port with --fleet-server-port

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-04-17T20:11:08.400+0000

• Duration: 14 min 13 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[jen-huang]

@nchaulet If these fields were never used in any version of Fleet Server, I don't think we need to restrict a higher Kibana version. However, I would like to check on what will happen if these vars are defined in preconfiguration, but is not present on the latest version of the package.

The reason I am asking is because on Cloud, our stackpack has these fields defined and they will always use the latest version of the Fleet Server package available to the version for that instance:
https://github.com/elastic/cloud-assets/blob/master/stackpack/kibana/config/kibana-7.yml
https://github.com/elastic/cloud-assets/blob/master/stackpack/kibana/config/kibana.yml

Could you check the behavior? If there is an issue, then we may need to restrict these changes to >v8.8.0.

[jen-huang]

if none of the optional fields below are present, is there any issue with having this empty server value?

[nchaulet]

it still will be a valid yaml

[nchaulet]

Could you check the behavior? If there is an issue, then we may need to restrict these changes to >v8.8.0.

@jen-huang I just tested a fleet server pre-configuration with some port and hosts and looks like we do not validate extra variables so we should be okay here.

I just did a test with fleet server 7.17 and in this case the host and port for the package policy is used, to be safe I think it will make sense to restrict that change to 8.8+

[jen-huang]

I just did a test with fleet server 7.17 and in this case the host and port for the package policy is used, to be safe I think it will make sense to restrict that change to 8.8+

@nchaulet Thanks for catching that. Let's restrict it then. Could you also update the 8.x stackpack so that we don't add these fields for 8.8+?

[michalpristas]

looks good

[elasticmachine]

Package fleet_server - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=fleet_server