Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kafka][TSDB] Added Dimension field mapping for Broker datastream #5925

Merged
merged 13 commits into from
Apr 25, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Apr 19, 2023

Type of change

  • Enhancement

What does this PR do?

Added metric_type mapping for broker datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@agithomas agithomas requested a review from a team as a code owner April 19, 2023 14:02
@agithomas agithomas force-pushed the issue-5905-kafka-tsdb-dim-broker branch from d4c50b7 to b004d5e Compare April 19, 2023 14:06
@agithomas agithomas mentioned this pull request Apr 19, 2023
16 tasks
@elasticmachine
Copy link

elasticmachine commented Apr 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-21T03:36:14.234+0000

  • Duration: 13 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 19, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 72.222% (13/18)
Lines 77.778% (56/72)
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agithomas agithomas merged commit d7be3e3 into elastic:main Apr 25, 2023
@elasticmachine
Copy link

Package kafka - 1.5.3 containing this change is available at https://epr.elastic.co/search?package=kafka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants