Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define sample tests for AWS EC2 module #599

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Define sample tests for AWS EC2 module #599

merged 2 commits into from
Feb 1, 2021

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Feb 1, 2021

What does this PR do?

This PR enables the AWS service deployer and adds sample tests for AWS EC2.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.

How to test this PR locally

The CI will verify it.

Related issues

@mtojek mtojek self-assigned this Feb 1, 2021
@mtojek mtojek mentioned this pull request Feb 1, 2021
Closed
@mtojek mtojek marked this pull request as ready for review February 1, 2021 10:19
@mtojek mtojek changed the title Define tests for AWS EC2 module Define sample tests for AWS EC2 module Feb 1, 2021
@elasticmachine
Copy link

elasticmachine commented Feb 1, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #599 updated

    • Start Time: 2021-02-01T10:21:15.861+0000

  • Duration: 28 min 52 sec

  • Commit: 687f883

Test stats 🧪

Test Results
Failed 0
Passed 1518
Skipped 0
Total 1518

ycombinator
ycombinator approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek mtojek merged commit 07b1e0b into elastic:master Feb 1, 2021
kaiyan-sheng
kaiyan-sheng reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just saw this!

eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@mtojek
Define sample tests for AWS EC2 module (elastic#599)
ae56884 
* Define tests for AWS EC2 module

* nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng left review comments

@ycombinator ycombinator ycombinator approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtojek @elasticmachine @ycombinator @kaiyan-sheng