Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vsphere] Add dimensions field mapping for virtualmachine datastrea… #6333

Merged
merged 6 commits into from
Jun 1, 2023
Merged

[Vsphere] Add dimensions field mapping for virtualmachine datastrea… #6333

merged 6 commits into from
Jun 1, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented May 26, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

This PR adds dimension fields mapping for virtual machine data stream of Sphere to support TSDB enablement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar ritalwar mentioned this pull request May 26, 2023
Closed
16 tasks
@ritalwar ritalwar marked this pull request as ready for review May 26, 2023 07:40
@ritalwar ritalwar requested a review from a team as a code owner May 26, 2023 07:40
shmsr
shmsr requested changes May 26, 2023
View reviewed changes
packages/vsphere/docs/README.md Outdated Show resolved Hide resolved
packages/vsphere/changelog.yml Outdated Show resolved Hide resolved
@shmsr shmsr mentioned this pull request May 26, 2023
Merged
4 tasks
@elasticmachine
Copy link

elasticmachine commented May 30, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-01T05:56:17.951+0000

  • Duration: 16 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 30, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (18/18) 💚
Lines 89.13% (41/46) 👍
Conditionals 100.0% (0/0) 💚

agithomas
agithomas approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shmsr shmsr mentioned this pull request May 31, 2023
Merged
6 tasks
@ritalwar ritalwar changed the title [Vsphere] Added dimensions field mapping for virtualmachine datastrea… [Vsphere] Add dimensions field mapping for virtualmachine datastrea… Jun 1, 2023
@ritalwar ritalwar merged commit 6a49ad8 into elastic:main Jun 1, 2023
@elasticmachine
Copy link

Package vsphere - 1.7.2 containing this change is available at https://epr.elastic.co/search?package=vsphere

agithomas pushed a commit to agithomas/integrations that referenced this pull request Jun 5, 2023
@ritalwar @agithomas
[Vsphere] Add dimensions field mapping for virtualmachine datastrea… (e…
4b08500 
…lastic#6333)

* [Vsphere] Add dimensions field mapping for virtualmachine datastream to support TSDB.
@shmsr shmsr mentioned this pull request Jun 5, 2023
Merged
4 tasks
sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@ritalwar @sodhikirti07
[Vsphere] Add dimensions field mapping for virtualmachine datastrea… (#…
81d4ea9 
…6333)

* [Vsphere] Add dimensions field mapping for virtualmachine datastream to support TSDB.
@andrewkroh andrewkroh added the Integration:vsphere VMware vSphere label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@shmsr shmsr shmsr approved these changes

Assignees
No one assigned
Labels
Integration:vsphere VMware vSphere
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ritalwar @elasticmachine @shmsr @agithomas @andrewkroh