-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elastic Agent] Set metric type #7033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
constanca-m
added
Team:Elastic-Agent
Label for the Agent team
Integration:elastic_agent
Elastic Agent
labels
Jul 20, 2023
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
5 tasks
🌐 Coverage report
|
cmacknz
reviewed
Jul 24, 2023
packages/elastic_agent/data_stream/elastic_agent_metrics/fields/fields.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: constanca-m <[email protected]>
cmacknz
reviewed
Jul 31, 2023
packages/elastic_agent/data_stream/apm_server_metrics/fields/beat-fields.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
cmacknz
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set metric type for metric fields missing it.
For the
filebeat_input
data stream:object
type fields had to be converted for numeric field types. The reason for this is explained in this issue.*.histogram.count
is a gauge? My reasoning is that the next value can be less than the current value, so it keeps going up and down. Because of that it cannot be a counter.*.histogram.*
is a gauge for the same reasoning?Checklist
changelog.yml
file.Related issues
Relates to #6938.