Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Redis] Update value format of Top Slowest command visualization #8186

Merged
merged 5 commits into from
Oct 26, 2023
Merged

[O11y][Redis] Update value format of Top Slowest command visualization #8186

merged 5 commits into from
Oct 26, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Oct 13, 2023 •
edited
Loading

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

Update value format of Top Slowest command visualization from Logs Overview dashboard once human readable format ( Seconds / Minutes / Hours ) is available in lens.
[Reference]

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before

image

After

image

@rajvi-patel-22 rajvi-patel-22 self-assigned this Oct 13, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 13, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-25T06:56:15.322+0000

  • Duration: 14 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 13, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 66.667% (14/21) 👎 -23.81
Lines 94.253% (82/87) 👎 -3.059
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review October 13, 2023 09:18
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner October 13, 2023 09:18
milan-elastic
milan-elastic approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

agithomas commented Oct 19, 2023 •
edited
Loading

@rajvi-elastic , Is it possible that in the horizontal axis it is mentioned as Duration (ms) , as in the past and value is shown as 20, 30, 40... ?

its not very user-friendly to display 'millisecond' repeated in the horizontal axis.

@rajvi-patel-22
Copy link
Contributor Author

@rajvi-elastic , Is it possible that in the horizontal axis it is mentioned as Duration (ms) , as in the past and value is shown as 20, 30, 40... ?

its not very user-friendly to display 'millisecond' repeated in the horizontal axis.

Yes @agithomas, I have just checked and there is one parameter using which we can compact unit. I'll update PR with the changes.
image

@rajvi-patel-22
Merge branch 'main' of https://github.com/rajvi-elastic/integrations …
6f09be8 
…into add_human_readable_format_redis

Conflicts:
	packages/redis/changelog.yml
	packages/redis/manifest.yml
@rajvi-patel-22
Compact x-axis label
9b046bf
@rajvi-patel-22
Copy link
Contributor Author

Yes @agithomas, I have just checked and there is one parameter using which we can compact unit. I'll update PR with the changes. image

@agithomas, I have updated PR.

@agithomas
Copy link
Contributor

What is the reason for the change in kibana version ? is this fix available only from 8.10?

@rajvi-patel-22
Copy link
Contributor Author

What is the reason for the change in kibana version ? is this fix available only from 8.10?

Yes, that's right. (reference)

agithomas
agithomas approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit 1b9082e into elastic:main Oct 26, 2023
1 check passed
@elasticmachine
Copy link

Package redis - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=redis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@agithomas agithomas agithomas approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
Integration:redis Redis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][Redis] Update human readable format in Logs Overview dashboard
5 participants
@rajvi-patel-22 @elasticmachine @agithomas @milan-elastic @andrewkroh