Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start of benchmark integration #8733

Closed
wants to merge 3 commits into from

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Dec 13, 2023

Proposed commit message

Integration for the new Filebeat benchmark input.

Included Dashboard to visualize events/sec.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Kibana version will need to be updated to match when benchmark input is available

How to test this PR locally

  1. checkout PR

  2. elastic-package build

  3. elastic-package stack up --version 8.11.2

  4. unpack elastic-agent distribution 8.11.2 for your client

  5. Add the following to the end of data/elastic-agent-<sha hash>/components/filebeat.spec.yml

      - name: benchmark
        description: "Benchmark"
        platforms: *platforms
        outputs: *outputs
        shippers: *shippers
        command: *command
  6. replace data/elastic-agent-<sha hash>/components/filebeat binary with one built with filebeat benchmark input and discard output beats#37437

  7. create new policy in fleet

  8. add benchmark integration to the policy (need to allow beta integrations)

  9. add your agent to the policy

  10. visualize performance with Dashboards

Related issues

Screenshots

Screenshot 2023-12-13 at 09 50 32 Screenshot 2023-12-13 at 09 50 05

@leehinman leehinman added enhancement New feature or request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] labels Dec 13, 2023
@leehinman leehinman requested review from a team, rdner and fearful-symmetry and removed request for a team December 13, 2023 19:58
@elasticmachine
Copy link

elasticmachine commented Dec 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-13T20:09:20.481+0000

  • Duration: 15 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.929
Classes 100.0% (0/0) 💚 3.929
Methods 33.333% (1/3) 👎 -59.074
Lines 100.0% (0/0) 💚 11.375
Conditionals 100.0% (0/0) 💚

@mrodm
Copy link
Contributor

mrodm commented Dec 21, 2023

Hi @leehinman, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@leehinman leehinman force-pushed the 2678_benchmark_integration branch from 5192097 to f9ccce0 Compare December 21, 2023 15:16
@botelastic
Copy link

botelastic bot commented Jan 20, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 20, 2024
@leehinman
Copy link
Contributor Author

I'm still working on this

@botelastic botelastic bot removed the Stalled label Jan 22, 2024
@botelastic
Copy link

botelastic bot commented Feb 21, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Feb 21, 2024
@botelastic
Copy link

botelastic bot commented Mar 22, 2024

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stalled Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants