-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y][Redis] Add AUTH (username) and SSL/TLS support #9777
[O11y][Redis] Add AUTH (username) and SSL/TLS support #9777
Conversation
🚀 Benchmarks reportTo see the full report comment with |
Co-authored-by: niraj-elastic <[email protected]>
packages/redis/manifest.yml
Outdated
# xw23l/k8RoD1wRWaDVbgpjwSzt+kl+vJE/ip2w3h69eEZ9wbo6scRO5lCO2JM4Pr | ||
# 7RhLQyWn2u00L7/9Omw= | ||
# -----END CERTIFICATE----- | ||
description: i.e. certificate_authorities, supported_protocols, verification_mode etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we improve the description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks weird. How does it show up on Kibana? Can you please see?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change it to something like this:
From ^^, we can probably do this?
This section allows for the configuration of SSL settings to enable secure communication between the client and server. Both common and specific SSL options can be customized to ensure a secure and reliable connection. Example: certificate_authorities, supported-protocols, verification-mode, key, certificate, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the certificate_authorities, links looks broken to me! Can you have a look and update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this link that you are suggesting to be there for certificate_authorities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this link that you are suggesting to be there for certificate_authorities?
Yep!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…arnish-elastic/integrations into redis-support-username-and-ssl
💚 Build Succeeded
History
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package redis - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=redis |
Proposed commit message
Add AUTH (username) and SSL/TLS support for key, keyspace, and info data streams.
Checklist
changelog.yml
file.Related issues