This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Cancel initialize job when removing workspace #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zfy0701 How do you think about this? |
movie-travel-code
approved these changes
Jun 17, 2019
| return null; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Please leave a new line at the end of the file. It's optional.
|
Upstream PR eclipse-jdtls/eclipse.jdt.ls#1064 was merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: https://github.com/elastic/code/issues/1187
When creating the initialize job, I set the root uri as a part of the job's name. Then when the
didChangeWorkspaceFoldersis called, It will check all initialization job to see if any job's name matches the removed workspace's uri and cancel it.The problem is that we still need cancel the update workspace job, which means I still rewrite another handler, adding more duplicated code.
The best solution is patching these logic to upstream, but not sure if they will accept it.
belongsToinstead of adding uri to job's name