Set VEGA_DEBUG only in the editor

elastic · Jan 13, 2018 · 28324c5 · 28324c5
1 parent c97e352
commit 28324c5
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/core_plugins/vega/public/vega_view/vega_base_view.js b/src/core_plugins/vega/public/vega_view/vega_base_view.js
@@ -9,8 +9,9 @@ vega.scheme('elastic',
 );
 
 export class VegaBaseView {
-  constructor(vegaConfig, parentEl, vegaParser, serviceSettings) {
+  constructor(vegaConfig, editorMode, parentEl, vegaParser, serviceSettings) {
     this._vegaConfig = vegaConfig;
+    this._editorMode = editorMode;
     this._$parentEl = $(parentEl);
     this._parser = vegaParser;
     this._serviceSettings = serviceSettings;
@@ -123,7 +124,12 @@ export class VegaBaseView {
   /**
    * Set global debug variable to simplify vega debugging in console. Show info message first time
    */
-  static setDebugValues(view, spec, vlspec) {
+  setDebugValues(view, spec, vlspec) {
+    if (!this._editorMode) {
+      // VEGA_DEBUG should only be enabled in the editor mode
+      return;
+    }
+
     if (window) {
       if (window.VEGA_DEBUG === undefined && console) {
         console.log('%cWelcome to Kibana Vega Plugin!', 'font-size: 16px; font-weight: bold;');

diff --git a/src/core_plugins/vega/public/vega_view/vega_view.js b/src/core_plugins/vega/public/vega_view/vega_view.js
@@ -7,7 +7,7 @@ export class VegaView extends VegaBaseView {
     if (!this._$container) return;
 
     const view = new vega.View(vega.parse(this._parser.spec), this._vegaViewConfig);
-    VegaView.setDebugValues(view, this._parser.spec, this._parser.vlspec);
+    this.setDebugValues(view, this._parser.spec, this._parser.vlspec);
 
     view.warn = this.onWarn.bind(this);
     view.error = this.onError.bind(this);

diff --git a/src/core_plugins/vega/public/vega_visualization.js b/src/core_plugins/vega/public/vega_visualization.js
@@ -48,7 +48,7 @@ export function VegaVisualizationProvider(vegaConfig, serviceSettings) {
         if (vegaParser.useMap) {
           throw new Error('Map mode is not yet supported in Kibana Core. You must use Kibana Vega plugin');
         } else {
-          this._vegaView = new VegaView(vegaConfig, this._el, vegaParser, serviceSettings);
+          this._vegaView = new VegaView(vegaConfig, this._vis.editorMode, this._el, vegaParser, serviceSettings);
         }
         await this._vegaView.init();