Skip to content

Commit

Permalink
👌 Apply feedback suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
dej611 committed Nov 9, 2020
1 parent 2d8c7b4 commit 2d42ea9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/lens/public/pie_visualization/toolbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export function PieToolbar(props: VisualizationToolbarProps<PieVisualizationStat
title={i18n.translate('xpack.lens.pieChart.valuesLabel', {
defaultMessage: 'Labels',
})}
type="values"
type="labels"
groupPosition="left"
buttonDataTestSubj="lnsLabelsButton"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import { EuiIconLegend } from '../assets/legend';

const typeToIconMap: { [type: string]: string | IconType } = {
legend: EuiIconLegend as IconType,
values: 'visText',
numeric: 'number',
labels: 'visText',
values: 'number',
};

export interface ToolbarPopoverProps {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ export function XyToolbar(props: VisualizationToolbarProps<State>) {
title={i18n.translate('xpack.lens.xyChart.valuesLabel', {
defaultMessage: 'Values',
})}
type="numeric"
type="values"
groupPosition="left"
buttonDataTestSubj="lnsValuesButton"
isDisabled={!isValueLabelsEnabled && !isFittingEnabled}
Expand Down

0 comments on commit 2d42ea9

Please sign in to comment.