Merge branch 'master' of github.com:elastic/kibana into cases-rbac-bugs

.eslintrc.js

@@ -875,6 +875,16 @@ module.exports = {
       },
     },
 
+    /**
+     * Cases overrides
+     */
+    {
+      files: ['x-pack/plugins/cases/**/*.{js,mjs,ts,tsx}'],
+      rules: {
+        'no-duplicate-imports': 'error',
+      },
+    },
+
     /**
      * Security Solution overrides
      */

docs/developer/getting-started/monorepo-packages.asciidoc

@@ -87,6 +87,7 @@ yarn kbn watch-bazel
 - @kbn/monaco
 - @kbn/rule-data-utils
 - @kbn/securitysolution-es-utils
+- @kbn/securitysolution-hook-utils
 - @kbn/securitysolution-io-ts-alerting-types
 - @kbn/securitysolution-io-ts-list-types
 - @kbn/securitysolution-io-ts-types

package.json

@@ -141,6 +141,7 @@
     "@kbn/rule-data-utils": "link:bazel-bin/packages/kbn-rule-data-utils",
     "@kbn/securitysolution-list-constants": "link:bazel-bin/packages/kbn-securitysolution-list-constants",
     "@kbn/securitysolution-es-utils": "link:bazel-bin/packages/kbn-securitysolution-es-utils",
+    "@kbn/securitysolution-hook-utils": "link:bazel-bin/packages/kbn-securitysolution-hook-utils",
     "@kbn/securitysolution-io-ts-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-types",
     "@kbn/securitysolution-io-ts-alerting-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-alerting-types",
     "@kbn/securitysolution-io-ts-list-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-list-types",

packages/BUILD.bazel

@@ -40,6 +40,7 @@ filegroup(
       "//packages/kbn-securitysolution-list-utils:build",
       "//packages/kbn-securitysolution-utils:build",
       "//packages/kbn-securitysolution-es-utils:build",
+      "//packages/kbn-securitysolution-hook-utils:build",
       "//packages/kbn-server-http-tools:build",
       "//packages/kbn-server-route-repository:build",
       "//packages/kbn-std:build",

packages/kbn-optimizer/limits.yml

@@ -108,6 +108,6 @@ pageLoadAssetSize:
   banners: 17946
   mapsEms: 26072
   timelines: 28613
-  cases: 162385
   screenshotMode: 17856
   visTypePie: 35583
+  cases: 144442

packages/kbn-securitysolution-hook-utils/BUILD.bazel

@@ -0,0 +1,87 @@
+load("@npm//@bazel/typescript:index.bzl", "ts_config", "ts_project")
+load("@build_bazel_rules_nodejs//:index.bzl", "js_library", "pkg_npm")
+
+PKG_BASE_NAME = "kbn-securitysolution-hook-utils"
+
+PKG_REQUIRE_NAME = "@kbn/securitysolution-hook-utils"
+
+SOURCE_FILES = glob(
+  [
+    "src/**/*.ts",
+  ],
+  exclude = [
+    "**/*.test.*",
+    "**/*.mock.*",
+  ],
+)
+
+SRCS = SOURCE_FILES
+
+filegroup(
+  name = "srcs",
+  srcs = SRCS,
+)
+
+NPM_MODULE_EXTRA_FILES = [
+  "package.json",
+  "README.md",
+]
+
+SRC_DEPS = [
+  "@npm//react",
+  "@npm//rxjs",
+  "@npm//tslib",
+]
+
+TYPES_DEPS = [
+  "@npm//@types/jest",
+  "@npm//@types/node",
+  "@npm//@types/react",
+]
+
+DEPS = SRC_DEPS + TYPES_DEPS
+
+ts_config(
+  name = "tsconfig",
+  src = "tsconfig.json",
+  deps = [
+      "//:tsconfig.base.json",
+  ],
+)
+
+ts_project(
+  name = "tsc",
+  srcs = SRCS,
+  args = ["--pretty"],
+  declaration = True,
+  declaration_map = True,
+  incremental = True,
+  out_dir = "target",
+  root_dir = "src",
+  source_map = True,
+  tsconfig = ":tsconfig",
+  deps = DEPS,
+)
+
+js_library(
+  name = PKG_BASE_NAME,
+  package_name = PKG_REQUIRE_NAME,
+  srcs = NPM_MODULE_EXTRA_FILES,
+  visibility = ["//visibility:public"],
+  deps = DEPS + [":tsc"],
+)
+
+pkg_npm(
+  name = "npm_module",
+  deps = [
+      ":%s" % PKG_BASE_NAME,
+  ],
+)
+
+filegroup(
+  name = "build",
+  srcs = [
+      ":npm_module",
+  ],
+  visibility = ["//visibility:public"],
+)

packages/kbn-securitysolution-hook-utils/README.md

@@ -0,0 +1,3 @@
+# kbn-securitysolution-hook-utils
+
+This package contains shared utilities for React hooks.

packages/kbn-securitysolution-hook-utils/jest.config.js

@@ -0,0 +1,13 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+module.exports = {
+  preset: '@kbn/test',
+  rootDir: '../..',
+  roots: ['<rootDir>/packages/kbn-securitysolution-hook-utils'],
+};

packages/kbn-securitysolution-hook-utils/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "@kbn/securitysolution-hook-utils",
+  "version": "1.0.0",
+  "description": "Security Solution utilities for React hooks",
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "main": "./target/index.js",
+  "types": "./target/index.d.ts",
+  "private": true
+}

packages/kbn-securitysolution-hook-utils/src/index.ts

@@ -0,0 +1,12 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export * from './use_async';
+export * from './use_is_mounted';
+export * from './use_observable';
+export * from './with_optional_signal';

packages/kbn-securitysolution-hook-utils/src/types.ts

@@ -0,0 +1,18 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+/**
+ * Represents the state of an asynchronous task, along with an initiator
+ * function to kick off the work.
+ */
+export interface Task<Args extends unknown[], Result> {
+  loading: boolean;
+  error: unknown | undefined;
+  result: Result | undefined;
+  start: (...args: Args) => void;
+}

packages/kbn-securitysolution-list-hooks/src/use_async/index.ts → packages/kbn-securitysolution-hook-utils/src/use_async/index.ts

@@ -8,26 +8,26 @@
 
 import { useCallback, useState } from 'react';
 
+import { Task } from '../types';
 import { useIsMounted } from '../use_is_mounted';
 
-// TODO: This is probably better off in another package such as kbn-securitysolution-hook-utils
-
-export interface Async<Args extends unknown[], Result> {
-  loading: boolean;
-  error: unknown | undefined;
-  result: Result | undefined;
-  start: (...args: Args) => void;
-}
-
 /**
  *
- * @param fn Async function
+ * This hook wraps a promise-returning thunk (task) in order to conditionally
+ * initiate the work, and automatically provide state corresponding to the
+ * task's status.
+ *
+ * In order to function properly and not rerender unnecessarily, ensure that
+ * your task is a stable function reference.
+ *
+ * @param fn a function returning a promise.
  *
- * @returns An {@link AsyncTask} containing the underlying task's state along with a start callback
+ * @returns An {@link Task} containing the task's current state along with a
+ * start callback
  */
 export const useAsync = <Args extends unknown[], Result>(
   fn: (...args: Args) => Promise<Result>
-): Async<Args, Result> => {
+): Task<Args, Result> => {
   const isMounted = useIsMounted();
   const [loading, setLoading] = useState(false);
   const [error, setError] = useState<unknown | undefined>();

packages/kbn-securitysolution-list-hooks/src/use_is_mounted/index.ts → packages/kbn-securitysolution-hook-utils/src/use_is_mounted/index.ts

@@ -10,8 +10,6 @@ import { useCallback, useEffect, useRef } from 'react';
 
 type GetIsMounted = () => boolean;
 
-// TODO: This is probably better off in another package such as kbn-securitysolution-hook-utils
-
 /**
  *
  * @returns A {@link GetIsMounted} getter function returning whether the component is currently mounted