feedback

elastic · Jul 5, 2022 · 33e0022 · 33e0022
1 parent c4931aa
commit 33e0022
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx
@@ -355,7 +355,7 @@ export const lastValueOperation: OperationDefinition<
               'xpack.lens.indexPattern.lastValue.showArrayValuesWithTopValuesWarning',
               {
                 defaultMessage:
-                  'When you show array values, you are unable to use this field to rank Top values.',
+                  'When you show array values, you are unable to use this field to rank top values.',
               }
             )}
             isInvalid={currentColumn.params.showArrayValues && usingTopValues}

diff --git a/...ens/public/indexpattern_datasource/operations/definitions/shared_components/form_row.scss b/...ens/public/indexpattern_datasource/operations/definitions/shared_components/form_row.scss
@@ -1,3 +1,3 @@
-.lnsInnerIndexPattern__inlineRow {
+.lnsIndexPatternDimensionEditor__labelCustomRank {
   min-width: 96px;
 }
diff --git a/...lens/public/indexpattern_datasource/operations/definitions/shared_components/form_row.tsx b/...lens/public/indexpattern_datasource/operations/definitions/shared_components/form_row.tsx
@@ -19,7 +19,11 @@ export const FormRow = ({ children, label, isInline, ...props }: FormRowProps) =
   ) : (
     <div data-test-subj={props['data-test-subj']}>
       {React.cloneElement(children, {
-        prepend: <EuiFormLabel className="lnsInnerIndexPattern__inlineRow">{label}</EuiFormLabel>,
+        prepend: (
+          <EuiFormLabel className="lnsIndexPatternDimensionEditor__labelCustomRank">
+            {label}
+          </EuiFormLabel>
+        ),
       })}
     </div>
   );

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/terms/index.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/terms/index.tsx
@@ -1012,10 +1012,10 @@ function getLabelForRankFunctions(operationType: string) {
           defaultMessage: 'Sort rank by',
         }),
       ];
-    case 'percentile':
+    case 'percentile_rank':
       return [
         i18n.translate('xpack.lens.indexPattern.terms.percentile.', {
-          defaultMessage: 'Rank percentile',
+          defaultMessage: 'Percentile ranks',
         }),
       ];
     default: