Skip to content

Commit

Permalink
[Security Solution] [Detections] Bug fix for read privilege check dur…
Browse files Browse the repository at this point in the history
…ing rule exec (#86852)
dhurley14 authored Dec 23, 2020

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
1 parent e389605 commit 35b10b5
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -197,13 +197,16 @@ describe('rules_notification_alert_type', () => {
'myfa*': {
read: true,
},
'anotherindex*': {
read: true,
},
'some*': {
read: false,
},
},
application: {},
});
payload.params.index = ['some*', 'myfa*'];
payload.params.index = ['some*', 'myfa*', 'anotherindex*'];
await alert.executor(payload);
expect(ruleStatusService.partialFailure).toHaveBeenCalled();
expect(ruleStatusService.partialFailure.mock.calls[0][0]).toContain(
Original file line number Diff line number Diff line change
@@ -189,10 +189,7 @@ export const signalRulesAlertType = ({
(indexName) => privileges.index[indexName].read
);

if (
indexesWithReadPrivileges.length > 0 &&
indexesWithNoReadPrivileges.length >= indexesWithReadPrivileges.length
) {
if (indexesWithReadPrivileges.length > 0 && indexesWithNoReadPrivileges.length > 0) {
// some indices have read privileges others do not.
// set a partial failure status
const errorString = `Missing required read permissions on indexes: ${JSON.stringify(

0 comments on commit 35b10b5

Please sign in to comment.