fix type check

elastic · Aug 5, 2021 · 49c1710 · 49c1710
1 parent 061a55f
commit 49c1710
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/dev_docs/getting_started/hello_world_plugin.mdx b/dev_docs/getting_started/hello_world_plugin.mdx
@@ -81,7 +81,8 @@ export class HelloWorldPlugin implements Plugin {
       id: 'helloWorld',
       title: 'Hello World',
       async mount({ element }: AppMountParameters) {
-        return ReactDOM.render(<div>Hello World!</div>, element);
+        ReactDOM.render(<div>Hello World!</div>, element);
+        return () => ReactDOM.unmountComponentAtNode(element);
       },
     });
   }

diff --git a/examples/hello_world/public/plugin.tsx b/examples/hello_world/public/plugin.tsx
@@ -21,7 +21,8 @@ export class HelloWorldPlugin implements Plugin<void, void, SetupDeps> {
       id: 'helloWorld',
       title: 'Hello World',
       async mount({ element }: AppMountParameters) {
-        return ReactDOM.render(<div id="helloWorldDiv">Hello World!</div>, element);
+        ReactDOM.render(<div id="helloWorldDiv">Hello World!</div>, element);
+        return () => ReactDOM.unmountComponentAtNode(element);
       },
     });