fix type, add filter icon, add text

elastic · Mar 24, 2020 · 4a8d4a1 · 4a8d4a1
1 parent c3708ca
commit 4a8d4a1
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/plugins/data/public/actions/apply_filter_action.ts b/src/plugins/data/public/actions/apply_filter_action.ts
@@ -42,6 +42,7 @@ export function createFilterAction(
   return createAction<typeof ACTION_GLOBAL_APPLY_FILTER>({
     type: ACTION_GLOBAL_APPLY_FILTER,
     id: ACTION_GLOBAL_APPLY_FILTER,
+    getIconType: () => 'filter',
     getDisplayName: () => {
       return i18n.translate('data.filter.applyFilterActionTitle', {
         defaultMessage: 'Apply filter to current view',

diff --git a/src/plugins/data/public/actions/select_range_action.ts b/src/plugins/data/public/actions/select_range_action.ts
@@ -80,6 +80,7 @@ export function selectRangeAction(
   return createAction<typeof ACTION_SELECT_RANGE>({
     type: ACTION_SELECT_RANGE,
     id: ACTION_SELECT_RANGE,
+    getIconType: () => 'filter',
     getDisplayName: () => {
       return i18n.translate('data.filter.applyFilterActionTitle', {
         defaultMessage: 'Apply filter to current view',

diff --git a/src/plugins/data/public/actions/value_click_action.ts b/src/plugins/data/public/actions/value_click_action.ts
@@ -128,6 +128,7 @@ export function valueClickAction(
   return createAction<typeof ACTION_VALUE_CLICK>({
     type: ACTION_VALUE_CLICK,
     id: ACTION_VALUE_CLICK,
+    getIconType: () => 'filter',
     getDisplayName: () => {
       return i18n.translate('data.filter.applyFilterActionTitle', {
         defaultMessage: 'Apply filter to current view',

diff --git a/...hboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx b/...hboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx
@@ -8,10 +8,7 @@ import React from 'react';
 import { CoreStart } from 'src/core/public';
 import { reactToUiComponent } from '../../../../../../../src/plugins/kibana_react/public';
 import { SharePluginStart } from '../../../../../../../src/plugins/share/public';
-import {
-  DASHBOARD_APP_URL_GENERATOR,
-  DashboardContainerInput,
-} from '../../../../../../../src/plugins/dashboard/public';
+import { DASHBOARD_APP_URL_GENERATOR } from '../../../../../../../src/plugins/dashboard/public';
 import { VisualizeEmbeddableContract } from '../../../../../../../src/legacy/core_plugins/visualizations/public';
 import { PlaceContext, ActionContext, Config, CollectConfigProps } from './types';
 

diff --git a/x-pack/plugins/drilldowns/public/components/connected_flyout_manage_drilldowns/i18n.ts b/x-pack/plugins/drilldowns/public/components/connected_flyout_manage_drilldowns/i18n.ts
@@ -15,7 +15,7 @@ export const toastDrilldownCreated = {
   ),
   text: (drilldownName: string) =>
     i18n.translate('xpack.drilldowns.components.flyoutDrilldownWizard.toast.drilldownCreatedText', {
-      defaultMessage: 'You created "{drilldownName}"',
+      defaultMessage: 'You created "{drilldownName}", save dashboard to test.',
       values: {
         drilldownName,
       },
@@ -31,7 +31,7 @@ export const toastDrilldownEdited = {
   ),
   text: (drilldownName: string) =>
     i18n.translate('xpack.drilldowns.components.flyoutDrilldownWizard.toast.drilldownEditedText', {
-      defaultMessage: 'You edited "{drilldownName}"',
+      defaultMessage: 'You edited "{drilldownName}", save dashboard to test.',
       values: {
         drilldownName,
       },