resolve conflicts

elastic · Apr 7, 2020 · 514561b · 514561b
1 parent 8deeaa9
commit 514561b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/src/legacy/core_plugins/vis_type_vislib/public/plugin.ts b/src/legacy/core_plugins/vis_type_vislib/public/plugin.ts
@@ -111,6 +111,6 @@ export class VisTypeVislibPlugin implements Plugin<void, void> {
 
   public start(core: CoreStart, { data }: VisTypeVislibPluginStartDependencies) {
     setFormatService(data.fieldFormats);
-    setDataActions({ createFiltersFromEvent: data.actions.createFiltersFromEvent });
+    setDataActions(data.actions);
   }
 }
diff --git a/src/plugins/embeddable/public/lib/triggers/triggers.ts b/src/plugins/embeddable/public/lib/triggers/triggers.ts
@@ -25,12 +25,12 @@ export interface EmbeddableContext {
 }
 
 export interface EmbeddableVisTriggerContext<T extends IEmbeddable = IEmbeddable> {
-  embeddable: T;
-  timeFieldName: string;
+  embeddable?: T;
+  timeFieldName?: string;
   data: {
     e?: MouseEvent;
     data: unknown;
-    range: unknown;
+    range?: unknown;
   };
 }
 

diff --git a/...d_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx b/...d_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx
@@ -9,7 +9,6 @@ import { UrlGeneratorContract } from '../../../../../../../src/plugins/share/pub
 import { savedObjectsServiceMock } from '../../../../../../../src/core/public/mocks';
 import { dataPluginMock } from '../../../../../../../src/plugins/data/public/mocks';
 import { ActionContext, Config } from './types';
-import { VisualizeEmbeddableContract } from '../../../../../../../src/legacy/core_plugins/visualizations/public/';
 import {
   Filter,
   FilterStateStore,
@@ -21,6 +20,7 @@ import { esFilters } from '../../../../../../../src/plugins/data/public';
 
 // convenient to use real implementation here.
 import { createDirectAccessDashboardLinkGenerator } from '../../../../../../../src/plugins/dashboard/public/url_generator';
+import { VisualizeEmbeddableContract } from '../../../../../../../src/plugins/visualizations/public';
 
 describe('.isConfigValid()', () => {
   const drilldown = new DashboardToDashboardDrilldown({} as any);

diff --git a/...hboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx b/...hboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx
@@ -9,14 +9,14 @@ import { CoreStart } from 'src/core/public';
 import { reactToUiComponent } from '../../../../../../../src/plugins/kibana_react/public';
 import { SharePluginStart } from '../../../../../../../src/plugins/share/public';
 import { DASHBOARD_APP_URL_GENERATOR } from '../../../../../../../src/plugins/dashboard/public';
-import { VisualizeEmbeddableContract } from '../../../../../../../src/legacy/core_plugins/visualizations/public';
 import { PlaceContext, ActionContext, Config, CollectConfigProps } from './types';
 
 import { CollectConfigContainer } from './collect_config';
 import { DASHBOARD_TO_DASHBOARD_DRILLDOWN } from './constants';
 import { DrilldownDefinition as Drilldown } from '../../../../../drilldowns/public';
 import { txtGoToDashboard } from './i18n';
 import { DataPublicPluginStart, esFilters } from '../../../../../../../src/plugins/data/public';
+import { VisualizeEmbeddableContract } from '../../../../../../../src/plugins/visualizations/public';
 
 export interface Params {
   getSavedObjectsClient: () => Promise<CoreStart['savedObjects']['client']>;
@@ -69,7 +69,7 @@ export class DashboardToDashboardDrilldown
       timeRange: currentTimeRange,
       query,
       filters: currentFilters,
-    } = context.embeddable.getInput();
+    } = context.embeddable!.getInput();
 
     // if useCurrentDashboardFilters enabled, then preserve all the filters (pinned and unpinned)
     // otherwise preserve only pinned
@@ -87,7 +87,7 @@ export class DashboardToDashboardDrilldown
       // look up by range
       const { restOfFilters, timeRangeFilter } =
         (await selectRangeActionGetFilters({
-          timeFieldName: context.timeFieldName,
+          timeFieldName: context.timeFieldName!,
           data: context.data,
         })) || {};
       filters.push(...(restOfFilters || []));
@@ -96,7 +96,7 @@ export class DashboardToDashboardDrilldown
       }
     } else {
       const { restOfFilters, timeRangeFilter } = await valueClickActionGetFilters({
-        timeFieldName: context.timeFieldName,
+        timeFieldName: context.timeFieldName!,
         data: context.data,
       });
       filters.push(...(restOfFilters || []));