unskipping functional tests to check their flakiness

elastic · Mar 24, 2021 · 520c93b · 520c93b
1 parent f3908f7
commit 520c93b
Show file tree

Hide file tree

Showing 32 changed files with 43 additions and 43 deletions.
diff --git a/test/functional/apps/context/_discover_navigation.js b/test/functional/apps/context/_discover_navigation.js
@@ -106,7 +106,7 @@ export default function ({ getService, getPageObjects }) {
     });
 
     // flaky https://github.com/elastic/kibana/issues/93670
-    it.skip('navigates to doc view from embeddable', async () => {
+    it('navigates to doc view from embeddable', async () => {
       await PageObjects.common.navigateToApp('discover');
       await PageObjects.discover.saveSearch('my search');
       await PageObjects.header.waitUntilLoadingHasFinished();

diff --git a/test/functional/apps/dashboard/dashboard_save.ts b/test/functional/apps/dashboard/dashboard_save.ts
@@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const testSubjects = getService('testSubjects');
 
   // FLAKY: https://github.com/elastic/kibana/issues/89476
-  describe.skip('dashboard save', function describeIndexTests() {
+  describe('dashboard save', function describeIndexTests() {
     this.tags('includeFirefox');
     const dashboardName = 'Dashboard Save Test';
     const dashboardNameEnterKey = 'Dashboard Save Test with Enter Key';

diff --git a/test/functional/apps/dashboard/dashboard_unsaved_state.ts b/test/functional/apps/dashboard/dashboard_unsaved_state.ts
@@ -21,7 +21,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   let unsavedPanelCount = 0;
 
   // FLAKY: https://github.com/elastic/kibana/issues/91191
-  describe.skip('dashboard unsaved panels', () => {
+  describe('dashboard unsaved panels', () => {
     before(async () => {
       await esArchiver.load('dashboard/current/kibana');
       await kibanaServer.uiSettings.replace({

diff --git a/test/functional/apps/dashboard/embeddable_rendering.ts b/test/functional/apps/dashboard/embeddable_rendering.ts
@@ -91,7 +91,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   };
 
   // Failing: See https://github.com/elastic/kibana/issues/76245
-  describe.skip('dashboard embeddable rendering', function describeIndexTests() {
+  describe('dashboard embeddable rendering', function describeIndexTests() {
     before(async () => {
       await security.testUser.setRoles(['kibana_admin', 'animals', 'test_logstash_reader']);
       await esArchiver.load('dashboard/current/kibana');

diff --git a/test/functional/apps/dashboard/url_field_formatter.ts b/test/functional/apps/dashboard/url_field_formatter.ts
@@ -37,7 +37,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   };
 
   // FLAKY: https://github.com/elastic/kibana/issues/79463
-  describe.skip('Changing field formatter to Url', () => {
+  describe('Changing field formatter to Url', () => {
     before(async function () {
       await esArchiver.load('dashboard/current/kibana');
       await kibanaServer.uiSettings.replace({

diff --git a/test/functional/apps/discover/_data_grid_context.ts b/test/functional/apps/discover/_data_grid_context.ts
@@ -35,7 +35,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const browser = getService('browser');
 
   // FLAKY: https://github.com/elastic/kibana/issues/94545
-  describe.skip('discover data grid context tests', () => {
+  describe('discover data grid context tests', () => {
     before(async () => {
       await esArchiver.load('discover');
       await esArchiver.loadIfNeeded('logstash_functional');

diff --git a/test/functional/apps/discover/_data_grid_doc_table.ts b/test/functional/apps/discover/_data_grid_doc_table.ts
@@ -59,7 +59,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     });
 
     // flaky https://github.com/elastic/kibana/issues/94889
-    it.skip('should show popover with expanded cell content by click on expand button', async () => {
+    it('should show popover with expanded cell content by click on expand button', async () => {
       log.debug('open popover with expanded cell content to get json from the editor');
       const documentCell = await dataGrid.getCellElement(1, 3);
       await documentCell.click();

diff --git a/test/functional/apps/discover/_saved_queries.ts b/test/functional/apps/discover/_saved_queries.ts
@@ -27,7 +27,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const testSubjects = getService('testSubjects');
 
   // FLAKY: https://github.com/elastic/kibana/issues/89477
-  describe.skip('saved queries saved objects', function describeIndexTests() {
+  describe('saved queries saved objects', function describeIndexTests() {
     before(async function () {
       log.debug('load kibana index with default index pattern');
       await esArchiver.load('discover');

diff --git a/test/functional/apps/management/_scripted_fields.js b/test/functional/apps/management/_scripted_fields.js
@@ -346,7 +346,7 @@ export default function ({ getService, getPageObjects }) {
 
       //add a test to sort boolean
       //existing bug: https://github.com/elastic/kibana/issues/75519 hence the issue is skipped.
-      it.skip('should sort scripted field value in Discover', async function () {
+      it('should sort scripted field value in Discover', async function () {
         await testSubjects.click(`docTableHeaderFieldSort_${scriptedPainlessFieldName2}`);
         // after the first click on the scripted field, it becomes secondary sort after time.
         // click on the timestamp twice to make it be the secondary sort key.
@@ -424,7 +424,7 @@ export default function ({ getService, getPageObjects }) {
 
       //add a test to sort date scripted field
       //https://github.com/elastic/kibana/issues/75711
-      it.skip('should sort scripted field value in Discover', async function () {
+      it('should sort scripted field value in Discover', async function () {
         await testSubjects.click(`docTableHeaderFieldSort_${scriptedPainlessFieldName2}`);
         // after the first click on the scripted field, it becomes secondary sort after time.
         // click on the timestamp twice to make it be the secondary sort key.

diff --git a/test/functional/apps/management/_scripted_fields_preview.js b/test/functional/apps/management/_scripted_fields_preview.js
@@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }) {
   const SCRIPTED_FIELD_NAME = 'myScriptedField';
 
   // FLAKY: https://github.com/elastic/kibana/issues/89475
-  describe.skip('scripted fields preview', () => {
+  describe('scripted fields preview', () => {
     before(async function () {
       await browser.setWindowSize(1200, 800);
       await PageObjects.settings.createIndexPattern();

diff --git a/test/functional/apps/management/exports/_import_too_big.ndjson b/test/functional/apps/management/exports/_import_too_big.ndjson
diff --git a/test/functional/apps/saved_objects_management/edit_saved_object.ts b/test/functional/apps/saved_objects_management/edit_saved_object.ts
@@ -56,7 +56,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
   };
 
   // Flaky: https://github.com/elastic/kibana/issues/68400
-  describe.skip('saved objects edition page', () => {
+  describe('saved objects edition page', () => {
     beforeEach(async () => {
       await esArchiver.load('saved_objects_management/edit_saved_object');
     });

diff --git a/test/functional/apps/visualize/_visualize_listing.ts b/test/functional/apps/visualize/_visualize_listing.ts
@@ -13,7 +13,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const listingTable = getService('listingTable');
 
   // FLAKY: https://github.com/elastic/kibana/issues/40912
-  describe.skip('visualize listing page', function describeIndexTests() {
+  describe('visualize listing page', function describeIndexTests() {
     const vizName = 'Visualize Listing Test';
 
     describe('create and delete', function () {

diff --git a/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts b/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts
@@ -32,7 +32,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
   const savedQueryManagementComponent = getService('savedQueryManagementComponent');
 
   // FLAKY: https://github.com/elastic/kibana/issues/86950
-  describe.skip('dashboard feature controls security', () => {
+  describe('dashboard feature controls security', () => {
     before(async () => {
       await esArchiver.load('dashboard/feature_controls/security');
       await esArchiver.loadIfNeeded('logstash_functional');
@@ -109,7 +109,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       });
 
       // Can't figure out how to get this test to pass
-      it.skip(`create new dashboard shows addNew button`, async () => {
+      it(`create new dashboard shows addNew button`, async () => {
         await PageObjects.common.navigateToActualUrl(
           'dashboard',
           DashboardConstants.CREATE_NEW_DASHBOARD_URL,
@@ -321,7 +321,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       });
 
       // Has this behavior changed?
-      it.skip(`create new dashboard redirects to the home page`, async () => {
+      it(`create new dashboard redirects to the home page`, async () => {
         await PageObjects.common.navigateToActualUrl(
           'dashboard',
           DashboardConstants.CREATE_NEW_DASHBOARD_URL,
@@ -439,7 +439,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       });
 
       // Has this behavior changed?
-      it.skip(`create new dashboard redirects to the home page`, async () => {
+      it(`create new dashboard redirects to the home page`, async () => {
         await PageObjects.common.navigateToActualUrl(
           'dashboard',
           DashboardConstants.CREATE_NEW_DASHBOARD_URL,

diff --git a/x-pack/test/functional/apps/dashboard/reporting/README.md b/x-pack/test/functional/apps/dashboard/reporting/README.md
@@ -19,4 +19,4 @@ Every now and then visual changes will be made that will require the snapshots t
 3. **Download the reports, and save them into the `reports/baseline` folder.**
    Change the names of the PNG/PDF files to overwrite the stored baselines.
 
-The next time functional tests run, the generated reports will be compared to the latest image that you have saved :bowtie:
+The next time functional tests run, the generated reports will be compared to the latest image that you have saved :bowtie:
diff --git a/x-pack/test/functional/apps/discover/async_scripted_fields.js b/x-pack/test/functional/apps/discover/async_scripted_fields.js
@@ -20,7 +20,7 @@ export default function ({ getService, getPageObjects }) {
   const security = getService('security');
 
   // Failing: See https://github.com/elastic/kibana/issues/78553
-  describe.skip('async search with scripted fields', function () {
+  describe('async search with scripted fields', function () {
     this.tags(['skipFirefox']);
 
     before(async function () {
@@ -42,7 +42,7 @@ export default function ({ getService, getPageObjects }) {
       await security.testUser.restoreDefaults();
     });
 
-    it.skip('query should show failed shards pop up', async function () {
+    it('query should show failed shards pop up', async function () {
       if (false) {
         /* If you had to modify the scripted fields, you could un-comment all this, run it, use es_archiver to update 'kibana_scripted_fields_on_logstash'
          */
@@ -74,7 +74,7 @@ export default function ({ getService, getPageObjects }) {
       });
     });
 
-    it.skip('query return results with valid scripted field', async function () {
+    it('query return results with valid scripted field', async function () {
       if (false) {
         /* the commented-out steps below were used to create the scripted fields in the logstash-* index pattern
         which are now saved in the esArchive.

diff --git a/x-pack/test/functional/apps/grok_debugger/grok_debugger.js b/x-pack/test/functional/apps/grok_debugger/grok_debugger.js
@@ -12,7 +12,7 @@ export default function ({ getService, getPageObjects }) {
 
   const PageObjects = getPageObjects(['grokDebugger']);
   // FLAKY: https://github.com/elastic/kibana/issues/84440
-  describe.skip('grok debugger app', function () {
+  describe('grok debugger app', function () {
     this.tags('includeFirefox');
     before(async () => {
       await esArchiver.load('empty_kibana');
@@ -50,7 +50,7 @@ export default function ({ getService, getPageObjects }) {
     });
 
     describe('syntax highlighting', () => {
-      it.skip('applies the correct CSS classes', async () => {
+      it('applies the correct CSS classes', async () => {
         const grokPattern = '\\[(?:-|%{NUMBER:bytes:int})\\]';
 
         await grokDebugger.setPatternInput(grokPattern);

diff --git a/x-pack/test/functional/apps/infra/home_page.ts b/x-pack/test/functional/apps/infra/home_page.ts
@@ -22,7 +22,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
   const supertest = getService('supertest');
 
   // FLAKY: https://github.com/elastic/kibana/issues/75724
-  describe.skip('Home page', function () {
+  describe('Home page', function () {
     this.tags('includeFirefox');
     before(async () => {
       await esArchiver.load('empty_kibana');

diff --git a/x-pack/test/functional/apps/lens/chart_data.ts b/x-pack/test/functional/apps/lens/chart_data.ts
@@ -61,21 +61,21 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     // Partition chart tests have to be skipped until
     // https://github.com/elastic/elastic-charts/issues/917 gets fixed
-    it.skip('should render pie chart', async () => {
+    it('should render pie chart', async () => {
       await PageObjects.lens.switchToVisualization('pie');
       await PageObjects.lens.waitForVisualization();
       const data = await PageObjects.lens.getCurrentChartDebugState();
       assertMatchesExpectedData(data!);
     });
 
-    it.skip('should render donut chart', async () => {
+    it('should render donut chart', async () => {
       await PageObjects.lens.switchToVisualization('donut');
       await PageObjects.lens.waitForVisualization();
       const data = await PageObjects.lens.getCurrentChartDebugState();
       assertMatchesExpectedData(data!);
     });
 
-    it.skip('should render treemap chart', async () => {
+    it('should render treemap chart', async () => {
       await PageObjects.lens.switchToVisualization('treemap');
       await PageObjects.lens.waitForVisualization();
       const data = await PageObjects.lens.getCurrentChartDebugState();

diff --git a/x-pack/test/functional/apps/maps/feature_controls/maps_spaces.ts b/x-pack/test/functional/apps/maps/feature_controls/maps_spaces.ts
@@ -14,7 +14,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
   const appsMenu = getService('appsMenu');
 
   // FLAKY: https://github.com/elastic/kibana/issues/38414
-  describe.skip('spaces feature controls', () => {
+  describe('spaces feature controls', () => {
     before(async () => {
       PageObjects.maps.setBasePath('/s/custom_space');
     });

diff --git a/x-pack/test/functional/apps/maps/layer_errors.js b/x-pack/test/functional/apps/maps/layer_errors.js
@@ -10,7 +10,7 @@ import expect from '@kbn/expect';
 export default function ({ getPageObjects }) {
   const PageObjects = getPageObjects(['maps', 'header']);
 
-  describe.skip('layer errors', () => {
+  describe('layer errors', () => {
     before(async () => {
       await PageObjects.maps.loadSavedMap('layer with errors');
     });
@@ -90,7 +90,7 @@ export default function ({ getPageObjects }) {
       // Flaky test on cloud and windows when run against a snapshot build of 7.11.
       // https://github.com/elastic/kibana/issues/91043
 
-      it.skip('should diplay error message in layer panel', async () => {
+      it('should diplay error message in layer panel', async () => {
         const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME);
         expect(errorMsg).to.equal(
           `Unable to find EMS tile configuration for id: ${MISSING_EMS_ID}. Kibana is unable to access Elastic Maps Service. Contact your system administrator.`

diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/feature_importance.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/feature_importance.ts
@@ -15,7 +15,7 @@ export default function ({ getService }: FtrProviderContext) {
   const ml = getService('ml');
 
   // FLAKY: https://github.com/elastic/kibana/issues/93188
-  describe.skip('total feature importance panel and decision path popover', function () {
+  describe('total feature importance panel and decision path popover', function () {
     const testDataList: Array<{
       suiteTitle: string;
       archive: string;

diff --git a/x-pack/test/functional/apps/monitoring/elasticsearch/indices.js b/x-pack/test/functional/apps/monitoring/elasticsearch/indices.js
@@ -45,7 +45,7 @@ export default function ({ getService, getPageObjects }) {
     });
 
     // Revisit once https://github.com/elastic/eui/issues/1322 is resolved
-    it.skip('should show indices table with correct rows after sorting by Search Rate Desc', async () => {
+    it('should show indices table with correct rows after sorting by Search Rate Desc', async () => {
       await indicesList.clickSearchCol();
       await indicesList.clickSearchCol();
 

diff --git a/x-pack/test/functional/apps/monitoring/elasticsearch/shards.js b/x-pack/test/functional/apps/monitoring/elasticsearch/shards.js
@@ -17,7 +17,7 @@ export default function ({ getService, getPageObjects }) {
   const retry = getService('retry');
 
   // FLAKY: https://github.com/elastic/kibana/issues/47184
-  describe.skip('Elasticsearch shard legends', () => {
+  describe('Elasticsearch shard legends', () => {
     const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);
 
     before(async () => {

diff --git a/x-pack/test/functional/apps/monitoring/setup/metricbeat_migration.js b/x-pack/test/functional/apps/monitoring/setup/metricbeat_migration.js
@@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }) {
   const PageObjects = getPageObjects(['common', 'console']);
 
   // FLAKY: https://github.com/elastic/kibana/issues/74327
-  describe.skip('Setup mode metricbeat migration', function () {
+  describe('Setup mode metricbeat migration', function () {
     describe('setup mode btn', () => {
       const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);
 

diff --git a/x-pack/test/functional/apps/monitoring/time_filter.js b/x-pack/test/functional/apps/monitoring/time_filter.js
@@ -29,15 +29,15 @@ export default function ({ getService, getPageObjects }) {
     });
 
     // FLAKY: https://github.com/elastic/kibana/issues/48910
-    it.skip('should send another request when clicking Refresh', async () => {
+    it('should send another request when clicking Refresh', async () => {
       await testSubjects.click('querySubmitButton');
       const isLoading = await PageObjects.header.isGlobalLoadingIndicatorVisible();
       expect(isLoading).to.be(true);
     });
 
     // TODO: [cr] I'm not sure this test is any better than the above one, we might need to rely solely on unit tests
     // for this functionality
-    it.skip('should send another request when changing the time picker', async () => {
+    it('should send another request when changing the time picker', async () => {
       await PageObjects.timePicker.setAbsoluteRange(
         'Aug 15, 2016 @ 21:00:00.000',
         'Aug 16, 2016 @ 00:00:00.000'

diff --git a/x-pack/test/functional/apps/security/management.js b/x-pack/test/functional/apps/security/management.js
@@ -21,7 +21,7 @@ export default function ({ getService, getPageObjects }) {
   const CLONE_ROLES_PATH = `${ROLES_PATH}/clone`;
 
   // FLAKY: https://github.com/elastic/kibana/issues/61173
-  describe.skip('Management', function () {
+  describe('Management', function () {
     this.tags(['skipFirefox']);
 
     before(async () => {

diff --git a/x-pack/test/functional/apps/spaces/spaces_selection.ts b/x-pack/test/functional/apps/spaces/spaces_selection.ts
@@ -23,7 +23,7 @@ export default function spaceSelectorFunctonalTests({
   ]);
 
   // FLAKY: https://github.com/elastic/kibana/issues/51942
-  describe.skip('Spaces', function () {
+  describe('Spaces', function () {
     this.tags('includeFirefox');
     describe('Space Selector', () => {
       before(async () => {

diff --git a/x-pack/test/functional/apps/status_page/status_page.ts b/x-pack/test/functional/apps/status_page/status_page.ts
@@ -15,7 +15,7 @@ export default function statusPageFunctonalTests({
   const PageObjects = getPageObjects(['security', 'statusPage', 'home']);
 
   // FLAKY: https://github.com/elastic/kibana/issues/50448
-  describe.skip('Status Page', function () {
+  describe('Status Page', function () {
     this.tags(['skipCloud', 'includeFirefox']);
     before(async () => await esArchiver.load('empty_kibana'));
     after(async () => await esArchiver.unload('empty_kibana'));

diff --git a/x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts b/x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
@@ -19,7 +19,7 @@ export default function upgradeAssistantFunctionalTests({
   const retry = getService('retry');
 
   // Failing: See https://github.com/elastic/kibana/issues/86546
-  describe.skip('Upgrade Checkup', function () {
+  describe('Upgrade Checkup', function () {
     this.tags('includeFirefox');
 
     before(async () => {

diff --git a/x-pack/test/functional/apps/uptime/locations.ts b/x-pack/test/functional/apps/uptime/locations.ts
@@ -40,7 +40,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
   };
 
   // FLAKY: https://github.com/elastic/kibana/issues/85208
-  describe.skip('Observer location', () => {
+  describe('Observer location', () => {
     const start = '~ 15 minutes ago';
     const end = 'now';
 

diff --git a/x-pack/test/functional/apps/uptime/overview.ts b/x-pack/test/functional/apps/uptime/overview.ts
@@ -16,7 +16,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
   const testSubjects = getService('testSubjects');
 
   // FLAKY: https://github.com/elastic/kibana/issues/89072
-  describe.skip('overview page', function () {
+  describe('overview page', function () {
     const DEFAULT_DATE_START = 'Sep 10, 2019 @ 12:40:08.078';
     const DEFAULT_DATE_END = 'Sep 11, 2019 @ 19:40:08.078';