Skip to content

Commit

Permalink
[APM] Change plugin id for apm_oss to apmOss (#66164)
Browse files Browse the repository at this point in the history
* Change apm oss plugin name from apm_oss to apmOss

* change plugin name

* update apm_oss -> apmOss inn requiredPlugins

Co-authored-by: mohinderps <[email protected]>
  • Loading branch information
ogupte and mohinderps authored May 12, 2020
1 parent 1a43feb commit 531eb7c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/plugins/apm_oss/kibana.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"id": "apm_oss",
"id": "apmOss",
"version": "8.0.0",
"server": true,
"kibanaVersion": "kibana",
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"kibanaVersion": "kibana",
"requiredPlugins": [
"features",
"apm_oss",
"apmOss",
"data",
"home",
"licensing",
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/apm/server/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class APMPlugin implements Plugin<APMPluginSetup> {
public async setup(
core: CoreSetup,
plugins: {
apm_oss: APMOSSPluginSetup;
apmOss: APMOSSPluginSetup;
home: HomeServerPluginSetup;
licensing: LicensingPluginSetup;
cloud?: CloudSetup;
Expand All @@ -65,7 +65,7 @@ export class APMPlugin implements Plugin<APMPluginSetup> {
) {
this.logger = this.initContext.logger.get();
const config$ = this.initContext.config.create<APMXPackConfig>();
const mergedConfig$ = combineLatest(plugins.apm_oss.config$, config$).pipe(
const mergedConfig$ = combineLatest(plugins.apmOss.config$, config$).pipe(
map(([apmOssConfig, apmConfig]) => mergeConfigs(apmOssConfig, apmConfig))
);

Expand Down

0 comments on commit 531eb7c

Please sign in to comment.