remove the last TODO. url should be inlined with assetss server

elastic · Apr 27, 2020 · 5e5c145 · 5e5c145
1 parent 9f46398
commit 5e5c145
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/legacy/ui/ui_render/ui_render_mixin.js b/src/legacy/ui/ui_render/ui_render_mixin.js
@@ -157,13 +157,15 @@ export function uiRenderMixin(kbnServer, server, config) {
         ];
 
         // These paths should align with the bundle routes configured in
-        // src/optimize/bundles_route/bundles_route.js
-        // TODO check if it still required
+        // src/optimize/bundles_route/bundles_route.ts
         const publicPathMap = JSON.stringify({
-          core: `${regularBundlePath}/core/`,
+          core: `${regularBundlePath}/${buildHash}/core/`,
           'kbn-ui-shared-deps': `${regularBundlePath}/kbn-ui-shared-deps/`,
           ...uiPluginIds.reduce(
-            (acc, pluginId) => ({ ...acc, [pluginId]: `${regularBundlePath}/plugin/${pluginId}/` }),
+            (acc, pluginId) => ({
+              ...acc,
+              [pluginId]: `${regularBundlePath}/${buildHash}/plugin/${pluginId}/`,
+            }),
             {}
           ),
         });

diff --git a/src/optimize/bundles_route/bundles_route.ts b/src/optimize/bundles_route/bundles_route.ts
@@ -102,7 +102,6 @@ export function createBundlesRoute({
       })
     ),
     // for async chunks that loaded by webpack.
-    // we can configure it as publicPath in webpack though
     ...npUiPluginPublicDirs.map(({ id, path }) =>
       buildRouteForBundles({
         publicPath: `${basePublicPath}/bundles/plugin/${id}/`,