Skip to content

Commit

Permalink
Clean up saved object based embeddable examples (#162987)
Browse files Browse the repository at this point in the history
## Summary

These examples are outdated and don't show recent embeddable best
practices. They also use client-side saved object client and block
making `SavedObjectFinder` backward compatible
#162904 as the `foobar` saved
objects need to be added to content management. We decided that it is
better to clean them up, as fixing them is not a small effort and it is
not worth it on this point as a large embeddable refactor is coming.
  • Loading branch information
Dosant authored Aug 3, 2023
1 parent bb68c20 commit 65fd7ad
Show file tree
Hide file tree
Showing 47 changed files with 24 additions and 2,538 deletions.

This file was deleted.

11 changes: 0 additions & 11 deletions examples/embeddable_examples/common/index.ts

This file was deleted.

This file was deleted.

9 changes: 1 addition & 8 deletions examples/embeddable_examples/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,10 @@
"requiredPlugins": [
"embeddable",
"uiActions",
"savedObjects",
"dashboard",
"kibanaUtils"
],
"requiredBundles": [
"kibanaReact"
],
"extraPublicDirs": [
"public/todo",
"public/hello_world",
"public/todo/todo_ref_embeddable"
"public/hello_world"
]
}
}

This file was deleted.

100 changes: 0 additions & 100 deletions examples/embeddable_examples/public/book/book_component.tsx

This file was deleted.

134 changes: 0 additions & 134 deletions examples/embeddable_examples/public/book/book_embeddable.tsx

This file was deleted.

Loading

0 comments on commit 65fd7ad

Please sign in to comment.