Refactor: configuration is normal part of the scene

elastic · Feb 14, 2019 · 7fa8a1b · 7fa8a1b
1 parent 6c7eeec
commit 7fa8a1b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/x-pack/plugins/canvas/public/lib/aeroelastic/layout_functions.js b/x-pack/plugins/canvas/public/lib/aeroelastic/layout_functions.js
@@ -1018,7 +1018,7 @@ const preserveCurrentGroups = (shapes, selectedShapes) => ({ shapes, selectedSha
 export const getScene = state => state.currentScene;
 
 export const configuration = state => {
-  return state.configuration;
+  return state.currentScene.configuration;
 };
 
 export const getShapes = scene => scene.shapes;

diff --git a/x-pack/plugins/canvas/public/lib/aeroelastic_kibana.js b/x-pack/plugins/canvas/public/lib/aeroelastic_kibana.js
@@ -24,7 +24,6 @@ export const aeroelastic = {
     const updateScene = state.select((nextScene, primaryUpdate) => ({
       primaryUpdate,
       currentScene: nextScene,
-      configuration: nextScene.configuration,
     }))(layout.nextScene, layout.primaryUpdate);
 
     stores.get(page).setUpdater(updateScene);

diff --git a/x-pack/plugins/canvas/public/state/middleware/aeroelastic.js b/x-pack/plugins/canvas/public/state/middleware/aeroelastic.js
@@ -262,8 +262,7 @@ export const aeroelastic = ({ dispatch, getState }) => {
     aero.createStore(
       {
         primaryUpdate: null,
-        currentScene: { shapes: [] },
-        configuration: aeroelasticConfiguration,
+        currentScene: { shapes: [], configuration: aeroelasticConfiguration },
       },
       onChangeCallback,
       page