Skip to content

Commit

Permalink
[8.11] [Security Solution] Unskip tests for Detection Engine and Secu…
Browse files Browse the repository at this point in the history
…rity Solution API Integration tests (#169262) (#170218)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] Unskip tests for Detection Engine and Security
Solution API Integration tests
(#169262)](#169262)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Juan Pablo
Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-31T10:36:41Z","message":"[Security
Solution] Unskip tests for Detection Engine and Security Solution API
Integration tests (#169262)\n\n## Summary\r\n\r\n###
Changes\r\n\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/group4/telemetry/task_based/detection_rules.ts`\r\n**unskipped**\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/rule_execution_logic/machine_learning.ts`\r\n**unskipped**\r\n\r\n###
Related flaky test issues\r\n\r\n**Tests already moved
to\r\n`x-pack/test/security_solution_api_integration`**\r\n\r\n1.
https://github.com/elastic/kibana/issues/169055\r\n2.
https://github.com/elastic/kibana/issues/168775\r\nThis issue is
reported for the legacy test, but is now moved
to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/ips_text_array/text_array.ts`\r\n3.
https://github.com/elastic/kibana/issues/163511\r\nThis issue is
reported for the legacy test, but is now moved
to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/keyword.ts`\r\n\r\n-
Flaky test runner for above
tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631\r\n\r\n**Test
still in `x-pack/test/detection_engine_api_integration`**\r\n1.
https://github.com/elastic/kibana/issues/168415\r\n2.
https://github.com/elastic/kibana/issues/164318\r\n3.
https://github.com/elastic/kibana/issues/164313\r\n4.
https://github.com/elastic/kibana/issues/145776\r\n\r\n**Other**\r\n1.
https://github.com/elastic/kibana/issues/151636\r\n\r\n## Flaky test
runner link\r\n\r\nPart 1 -
`x-pack/test/detection_engine_api_integration` - tests not
yet\r\nmigrated\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3597\r\nPart
2 - `x-pack/test/security_solution_api_integration` - tests
already\r\nmoved\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631","sha":"9eff64a39120e364a4f9a6b71d9501dbb1be0999","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections
and Resp","Team:Detection
Engine","v8.11.0","v8.12.0"],"number":169262,"url":"https://github.com/elastic/kibana/pull/169262","mergeCommit":{"message":"[Security
Solution] Unskip tests for Detection Engine and Security Solution API
Integration tests (#169262)\n\n## Summary\r\n\r\n###
Changes\r\n\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/group4/telemetry/task_based/detection_rules.ts`\r\n**unskipped**\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/rule_execution_logic/machine_learning.ts`\r\n**unskipped**\r\n\r\n###
Related flaky test issues\r\n\r\n**Tests already moved
to\r\n`x-pack/test/security_solution_api_integration`**\r\n\r\n1.
https://github.com/elastic/kibana/issues/169055\r\n2.
https://github.com/elastic/kibana/issues/168775\r\nThis issue is
reported for the legacy test, but is now moved
to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/ips_text_array/text_array.ts`\r\n3.
https://github.com/elastic/kibana/issues/163511\r\nThis issue is
reported for the legacy test, but is now moved
to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/keyword.ts`\r\n\r\n-
Flaky test runner for above
tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631\r\n\r\n**Test
still in `x-pack/test/detection_engine_api_integration`**\r\n1.
https://github.com/elastic/kibana/issues/168415\r\n2.
https://github.com/elastic/kibana/issues/164318\r\n3.
https://github.com/elastic/kibana/issues/164313\r\n4.
https://github.com/elastic/kibana/issues/145776\r\n\r\n**Other**\r\n1.
https://github.com/elastic/kibana/issues/151636\r\n\r\n## Flaky test
runner link\r\n\r\nPart 1 -
`x-pack/test/detection_engine_api_integration` - tests not
yet\r\nmigrated\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3597\r\nPart
2 - `x-pack/test/security_solution_api_integration` - tests
already\r\nmoved\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631","sha":"9eff64a39120e364a4f9a6b71d9501dbb1be0999"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169262","number":169262,"mergeCommit":{"message":"[Security
Solution] Unskip tests for Detection Engine and Security Solution API
Integration tests (#169262)\n\n## Summary\r\n\r\n###
Changes\r\n\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/group4/telemetry/task_based/detection_rules.ts`\r\n**unskipped**\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/rule_execution_logic/machine_learning.ts`\r\n**unskipped**\r\n\r\n###
Related flaky test issues\r\n\r\n**Tests already moved
to\r\n`x-pack/test/security_solution_api_integration`**\r\n\r\n1.
https://github.com/elastic/kibana/issues/169055\r\n2.
https://github.com/elastic/kibana/issues/168775\r\nThis issue is
reported for the legacy test, but is now moved
to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/ips_text_array/text_array.ts`\r\n3.
https://github.com/elastic/kibana/issues/163511\r\nThis issue is
reported for the legacy test, but is now moved
to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/keyword.ts`\r\n\r\n-
Flaky test runner for above
tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631\r\n\r\n**Test
still in `x-pack/test/detection_engine_api_integration`**\r\n1.
https://github.com/elastic/kibana/issues/168415\r\n2.
https://github.com/elastic/kibana/issues/164318\r\n3.
https://github.com/elastic/kibana/issues/164313\r\n4.
https://github.com/elastic/kibana/issues/145776\r\n\r\n**Other**\r\n1.
https://github.com/elastic/kibana/issues/151636\r\n\r\n## Flaky test
runner link\r\n\r\nPart 1 -
`x-pack/test/detection_engine_api_integration` - tests not
yet\r\nmigrated\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3597\r\nPart
2 - `x-pack/test/security_solution_api_integration` - tests
already\r\nmoved\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631","sha":"9eff64a39120e364a4f9a6b71d9501dbb1be0999"}}]}]
BACKPORT-->

Co-authored-by: Juan Pablo Djeredjian <[email protected]>
  • Loading branch information
kibanamachine and jpdjere authored Oct 31, 2023
1 parent 96f5aa0 commit 8a3c213
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ export default ({ getService }: FtrProviderContext) => {
const log = getService('log');
const retry = getService('retry');

// Failing: See https://github.com/elastic/kibana/issues/164318
// FLAKY: https://github.com/elastic/kibana/issues/164313
describe.skip('Detection rule task telemetry', async () => {
describe('Detection rule task telemetry', async () => {
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/security_solution/telemetry');
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ export default ({ getService }: FtrProviderContext) => {
rule_id: 'ml-rule-id',
};

// FLAKY: https://github.com/elastic/kibana/issues/145776
describe.skip('Machine learning type rules', () => {
describe('Machine learning type rules', () => {
before(async () => {
// Order is critical here: auditbeat data must be loaded before attempting to start the ML job,
// as the job looks for certain indices on start
Expand Down

0 comments on commit 8a3c213

Please sign in to comment.