Skip to content

Commit

Permalink
Redesigns home page
Browse files Browse the repository at this point in the history
    Adds auto scroll to advanced setting provided in the URL hash

    Registered plugins to feature catalogue to be displayed on home page

    Rearrange add data section

    Fix solution panel conditional rendering

    Removed extraneous import

    Remmoved environment update from observability plugin

    Registrered features to feature catalog for ingest manager, ml, and index lifecycle management

    Fixed import

    Added max width to Kibana solution card

    Fixed feature id

    Fixed enterprise search link

    Updated solutions logos

    Fixed beta label on ingest manager card

    Fixed logos

    Cleaned up CSS

    Change home route redirects user to advanced settings

    Conditionally renders default route advanced setting link

    Restored app search logo

    Hides graph description on home page on basic license

    Style home page header and other misc design tweaks (#72481)

    Fixed home page header links spacing

    Hide solutions wrapper when no solutions are available

    Design PR: layout tweaks, responsive styles (#72944)

    * layout tweaks, responsive styles

    * address feedback, improve bg color setup

    * use EUI var for header height

    Fixed merge conflict

    Fixed click handler for change home route button

    Updated app directory link

    Moved app directory link from ChangeHomeRoute component to home component

    Updated tests

    Added FeatureCatalogueRegistryStart type

    Home page refactor

    Fixed prop types

    Fixed nav links

    Removed images from solution card components

    card images as backgrounds, consolidate styles, BEM changes

    style token icons for dark mode

    fix page height

    Updated home page feature order values

    Added solutions registry to feature catalogue

    Renamed solutions_panel to solutions_section

    Updated copy

    Removed imports

    Chore: makes home plugin optional dependency

    Fixed merge conflict

    Added tests for new home components

    Reverted component rename

    [Core UI] Home Page Redesign Class & Style Tweaks (#74037)

    Co-authored-by: Catherine Liu <[email protected]>
    Co-authored-by: Ryan Keairns <[email protected]>
    Co-authored-by: Catherine Liu <[email protected]>

    Fixed i18n errors

    Adde feature catalogue registry tests

    Rename components

Switched solution descriptions to static strings

Fixed registered features

Fixed i18n errors

Show/hide solutions based on available nav links

Removed solution property from feature catalogue entry

Revert text changes

Updated security link

Updated snapshots

Fixed home plugin tests

Added solutions section tests

Removed mock

Fixed tutorial directory a11y tests

Fix ui capabilities catalogue test

Turned solution title into link

Added tests

Fixed security solution tests

Fixed ts errors

Updated snapshots

Revert vega snapshot changes

Retrieves height of global nav when scrolling to a field in advanced settings

Removed a tag from solution panel title

Apply a11y feedback

Updated snapshots

Added proptypes

Updated chrome ui header snapshots

Fixed manage data tests
  • Loading branch information
cqliu1 committed Aug 18, 2020
1 parent 245c0a3 commit a53c715
Show file tree
Hide file tree
Showing 120 changed files with 3,996 additions and 2,930 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/core/public/chrome/ui/header/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export function Header({
<>
<LoadingIndicator loadingCount$={observables.loadingCount$} />
<header className={className} data-test-subj="headerGlobalNav">
<EuiHeader position="fixed">
<EuiHeader position="fixed" id="headerGlobalNav">
<EuiHeaderSection grow={false}>
{navType === 'modern' ? (
<EuiHeaderSectionItem border="right" className="header__toggleNavButtonSection">
Expand Down
2 changes: 1 addition & 1 deletion src/core/public/overlays/banners/_banners_list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
}

.kbnGlobalBannerList__item + .kbnGlobalBannerList__item {
margin-top: $euiSize;
margin-top: $euiSizeS;
}
2 changes: 1 addition & 1 deletion src/core/utils/default_app_categories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const DEFAULT_APP_CATEGORIES = Object.freeze({
order: 3000,
},
security: {
id: 'security',
id: 'securitySolution',
label: i18n.translate('core.ui.securityNavList.label', {
defaultMessage: 'Security',
}),
Expand Down
3 changes: 2 additions & 1 deletion src/plugins/advanced_settings/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
"server": true,
"ui": true,
"requiredPlugins": ["management"],
"requiredBundles": ["kibanaReact"]
"optionalPlugins": ["home"],
"requiredBundles": ["kibanaReact", "home"]
}
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,21 @@ export class AdvancedSettingsComponent extends Component<
filteredSettings: this.mapSettings(Query.execute(query, this.settings)),
});
});

// scrolls to setting provided in the URL hash
const { hash } = window.location;
if (hash !== '') {
setTimeout(() => {
const id = hash.replace('#', '');
const element = document.getElementById(id);
const globalNavOffset = document.getElementById('headerGlobalNav')?.offsetHeight || 0;

if (element) {
element.scrollIntoView();
window.scrollBy(0, -globalNavOffset); // offsets scroll by height of the global nav
}
}, 0);
}
}

componentWillUnmount() {
Expand Down
Loading

0 comments on commit a53c715

Please sign in to comment.