simplify code, add retry

elastic · Apr 19, 2024 · ab5dc59 · ab5dc59
1 parent 5c1438f
commit ab5dc59
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/test/functional/page_objects/settings_page.ts b/test/functional/page_objects/settings_page.ts
@@ -787,7 +787,12 @@ export class SettingsPageObject extends FtrService {
   ) {
     await this.clickAddField();
     await this.setFieldName(name);
-    await this.setFieldTypeComposite();
+
+    await this.retry.try(async () => {
+      await this.setFieldType('Composite');
+      const comboBox = await this.testSubjects.find('typeField');
+      expect(await this.comboBox.isOptionSelected(comboBox, 'Composite')).to.be(true);
+    });
     await this.setCompositeScript(script);
     if (subfieldCount > 0) {
       await this.testSubjects.find(`typeField_${subfieldCount - 1}`);
@@ -878,12 +883,6 @@ export class SettingsPageObject extends FtrService {
     await this.comboBox.set('typeField', type);
   }
 
-  async setFieldTypeComposite() {
-    this.log.debug('set type = Composite');
-    const comboBox = await this.testSubjects.find('typeField');
-    this.comboBox.setElement(comboBox, 'Composite');
-  }
-
   async setFieldScript(script: string) {
     this.log.debug('set script = ' + script);
     await this.toggleRow('valueRow');