Remove duplicated type in favor of common one

elastic · Sep 4, 2020 · b24742c · b24742c
1 parent e45c128
commit b24742c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/x-pack/plugins/security_solution/public/detections/components/rules/step_about_rule/data.tsx b/x-pack/plugins/security_solution/public/detections/components/rules/step_about_rule/data.tsx
@@ -8,11 +8,12 @@ import styled from 'styled-components';
 import { EuiHealth } from '@elastic/eui';
 import euiLightVars from '@elastic/eui/dist/eui_theme_light.json';
 import React from 'react';
-import { SeverityValue } from '../../../pages/detection_engine/rules/types';
+
+import { Severity } from '../../../../../common/detection_engine/schemas/common/schemas';
 import * as I18n from './translations';
 
 export interface SeverityOptionItem {
-  value: SeverityValue;
+  value: Severity;
   inputDisplay: React.ReactElement;
 }
 
@@ -43,7 +44,7 @@ export const severityOptions: SeverityOptionItem[] = [
   },
 ];
 
-export const defaultRiskScoreBySeverity: Record<SeverityValue, number> = {
+export const defaultRiskScoreBySeverity: Record<Severity, number> = {
   low: 21,
   medium: 47,
   high: 73,

diff --git a/x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/helpers.tsx b/x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/helpers.tsx
@@ -23,11 +23,11 @@ import {
   IMitreEnterpriseAttack,
   ScheduleStepRule,
   ActionsStepRule,
-  SeverityValue,
 } from './types';
 import {
   SeverityMapping,
   Type,
+  Severity,
 } from '../../../../../common/detection_engine/schemas/common/schemas';
 import { severityOptions } from '../../../components/rules/step_about_rule/data';
 
@@ -151,7 +151,7 @@ export const getAboutStepsData = (rule: Rule, detailsView: boolean): AboutStepRu
     note: note!,
     references,
     severity: {
-      value: severity as SeverityValue,
+      value: severity as Severity,
       mapping: fillEmptySeverityMappings(severityMapping),
       isMappingChecked: severityMapping.length > 0,
     },

diff --git a/x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/types.ts b/x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/types.ts
@@ -20,6 +20,7 @@ import {
   SortOrder,
   TimestampOverride,
   Type,
+  Severity,
 } from '../../../../../common/detection_engine/schemas/common/schemas';
 import { List } from '../../../../../common/detection_engine/schemas/types';
 
@@ -103,10 +104,8 @@ export interface AboutStepRuleDetails {
   description: string;
 }
 
-export type SeverityValue = 'low' | 'medium' | 'high' | 'critical';
-
 export interface AboutStepSeverity {
-  value: SeverityValue;
+  value: Severity;
   mapping: SeverityMapping;
   isMappingChecked: boolean;
 }