Skip to content

Commit

Permalink
switch to memo
Browse files Browse the repository at this point in the history
  • Loading branch information
dplumlee committed Jan 7, 2021
1 parent 16623df commit bfe9bca
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps> = ({

const { addWarning } = useAppToasts();

const getAlertStatus = useCallback(() => {
const alertStatus = useMemo(() => {
return ecsRowData.signal?.status && (ecsRowData.signal.status[0] as Status);
}, [ecsRowData]);

Expand Down Expand Up @@ -341,11 +341,11 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps> = ({
);

const statusFilters = useMemo(() => {
if (!getAlertStatus()) {
if (!alertStatus) {
return [];
}

switch (getAlertStatus()) {
switch (alertStatus) {
case 'open':
return [inProgressAlertActionComponent, closeAlertActionComponent];
case 'in-progress':
Expand All @@ -359,7 +359,7 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps> = ({
closeAlertActionComponent,
inProgressAlertActionComponent,
openAlertActionComponent,
getAlertStatus,
alertStatus,
]);

const items = useMemo(
Expand Down Expand Up @@ -393,7 +393,7 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps> = ({
alertData={ecsRowData}
onCancel={onAddExceptionCancel}
onConfirm={onAddExceptionConfirm}
alertStatus={getAlertStatus()}
alertStatus={alertStatus}
onRuleChange={onRuleChange}
/>
)}
Expand Down

0 comments on commit bfe9bca

Please sign in to comment.