[maps] remove tile_map, region_map, and maps_legacy plugins (#105326)

* [maps] remove tile_map plugin

* initial bounds

* update embeddable query context

* start editor

* remove tile_map from tsconfig and i18n cleanup

* implement view in maps button

* tslint

* remove empty lines

* remove tileMap from limits.yml

* remove region_map and maps_legacy plugins

* region_map vis with Map embeddable

* make MapComponent

* lint

* clean up

* shorten text

* lint

* remove region_map from interpreter functional tests

* update docs

* add migration for removing ui_settings

* remove tile_map and region_map functional tests

* tslint

* call handlers.done when layers are loaded

* fix visualize create menu test

* eslint

* add owner comment to ui_settings/saved_objects/migrations.ts

* remove deleted plugins from codeowners

* review feedback

* use correct value for TILE_MAP_RENDER

* down select mapModules for getLayerDescriptors callback

Co-authored-by: Kibana Machine <[email protected]>

.github/CODEOWNERS

@@ -178,12 +178,8 @@
 /x-pack/test/visual_regression/tests/maps/index.js @elastic/kibana-gis
 /x-pack/plugins/stack_alerts/server/alert_types/geo_containment @elastic/kibana-gis
 /x-pack/plugins/stack_alerts/public/alert_types/geo_containment @elastic/kibana-gis
-#CC# /src/plugins/maps_legacy/ @elastic/kibana-gis
-/src/plugins/maps_legacy/ @elastic/kibana-gis
 #CC# /x-pack/plugins/file_upload @elastic/kibana-gis
 /x-pack/plugins/file_upload @elastic/kibana-gis
-/src/plugins/tile_map/ @elastic/kibana-gis
-/src/plugins/region_map/ @elastic/kibana-gis
 /packages/kbn-mapbox-gl @elastic/kibana-gis
 
 # Operations

.i18nrc.json

@@ -33,7 +33,6 @@
     "kbnDocViews": "src/legacy/core_plugins/kbn_doc_views",
     "lists": "packages/kbn-securitysolution-list-utils/src",
     "management": ["src/legacy/core_plugins/management", "src/plugins/management"],
-    "maps_legacy": "src/plugins/maps_legacy",
     "monaco": "packages/kbn-monaco/src",
     "esQuery": "packages/kbn-es-query/src",
     "presentationUtil": "src/plugins/presentation_util",
@@ -49,14 +48,12 @@
     "kibana_utils": "src/plugins/kibana_utils",
     "navigation": "src/plugins/navigation",
     "newsfeed": "src/plugins/newsfeed",
-    "regionMap": "src/plugins/region_map",
     "savedObjects": "src/plugins/saved_objects",
     "savedObjectsManagement": "src/plugins/saved_objects_management",
     "security": "src/plugins/security_oss",
     "server": "src/legacy/server",
     "statusPage": "src/legacy/core_plugins/status_page",
     "telemetry": ["src/plugins/telemetry", "src/plugins/telemetry_management_section"],
-    "tileMap": "src/plugins/tile_map",
     "timelion": ["src/plugins/timelion", "src/plugins/vis_type_timelion"],
     "uiActions": "src/plugins/ui_actions",
     "visDefaultEditor": "src/plugins/vis_default_editor",

docs/developer/plugin-list.asciidoc

@@ -182,10 +182,6 @@ management section itself.
 |Configuration of kibana-wide EMS settings and some higher level utilities.
 
 
-|{kib-repo}blob/{branch}/src/plugins/maps_legacy/README.md[mapsLegacy]
-|Internal objects used by the Coordinate, Region, and Vega visualizations.
-
-
 |{kib-repo}blob/{branch}/src/plugins/navigation/README.md[navigation]
 |The navigation plugins exports the TopNavMenu component.
 It also provides a stateful version of it on the start contract.
@@ -200,10 +196,6 @@ Content is fetched from the remote (https://feeds.elastic.co and https://feeds-s
 |The Presentation Utility Plugin is a set of common, shared components and toolkits for solutions within the Presentation space, (e.g. Dashboards, Canvas).
 
 
-|{kib-repo}blob/{branch}/src/plugins/region_map/README.md[regionMap]
-|Create choropleth maps. Display the results of a term-aggregation as e.g. countries, zip-codes, states.
-
-
 |{kib-repo}blob/{branch}/src/plugins/saved_objects/README.md[savedObjects]
 |NOTE: This plugin is deprecated and will be removed in 8.0. See https://github.com/elastic/kibana/issues/46435 for more information.
 
@@ -247,10 +239,6 @@ generating deep links to other apps, and creating short URLs.
 |This plugin adds the Advanced Settings section for the Usage and Security Data collection (aka Telemetry).
 
 
-|{kib-repo}blob/{branch}/src/plugins/tile_map/README.md[tileMap]
-|Create a coordinate map. Display the results of a geohash_tile aggregation as bubbles, rectangles, or heatmap color blobs.
-
-
 |{kib-repo}blob/{branch}/src/plugins/timelion/README.md[timelion]
 |Contains the deprecated timelion application. For the timelion visualization,
 which also contains the timelion APIs and backend, look at the vis_type_timelion plugin.

docs/management/advanced-options.asciidoc

@@ -534,17 +534,6 @@ of the chart. Use numbers between 0 and 1. The lower the number, the more the hi
 [[visualization-heatmap-maxbuckets]]`visualization:heatmap:maxBuckets`::
 The maximum number of buckets a datasource can return. High numbers can have a negative impact on your browser rendering performance.
 
-[[visualization-regionmap-showwarnings]]`visualization:regionmap:showWarnings`::
-Shows a warning in a region map when terms cannot be joined to a shape.
-
-[[visualization-tilemap-wmsdefaults]]`visualization:tileMap:WMSdefaults`::
-The default properties for the WMS map server supported in the coordinate map.
-
-[[visualization-tilemap-maxprecision]]`visualization:tileMap:maxPrecision`::
-The maximum geoHash precision displayed in tile maps. 7 is high, 10 is very high,
-and 12 is the maximum. For more information, refer to
-{ref}/search-aggregations-bucket-geohashgrid-aggregation.html#_cell_dimensions_at_the_equator[Cell dimensions at the equator].
-
 [[visualization-visualize-chartslibrary]]`visualization:visualize:legacyChartsLibrary`::
 **The legacy XY charts are deprecated and will not be supported as of 7.16.**
 The visualize editor uses a new XY charts library with improved performance, color palettes, fill capacity, and more. Enable this option if you prefer to use the legacy charts library.
@@ -563,4 +552,4 @@ only production-ready visualizations are available to users.
 [horizontal]
 [[telemetry-enabled-advanced-setting]]`telemetry:enabled`::
 When enabled, helps improve the Elastic Stack by providing usage statistics for
-basic features. This data will not be shared outside of Elastic.
+basic features. This data will not be shared outside of Elastic.

package.json

@@ -280,10 +280,6 @@
     "jsonwebtoken": "^8.5.1",
     "jsts": "^1.6.2",
     "kea": "^2.4.2",
-    "leaflet": "1.5.1",
-    "leaflet-draw": "0.4.14",
-    "leaflet-responsive-popup": "0.6.4",
-    "leaflet.heat": "0.2.0",
     "less": "npm:@elastic/[email protected]",
     "load-json-file": "^6.2.0",
     "loader-utils": "^1.2.3",

packages/kbn-optimizer/limits.yml

@@ -50,15 +50,13 @@ pageLoadAssetSize:
   lists: 22900
   logstash: 53548
   management: 46112
-  maps: 80000
-  mapsLegacy: 87859
+  maps: 90000
   ml: 82187
   monitoring: 80000
   navigation: 37269
   newsfeed: 42228
   observability: 89709
   painlessLab: 179748
-  regionMap: 66098
   remoteClusters: 51327
   reporting: 183418
   rollup: 97204
@@ -75,7 +73,6 @@ pageLoadAssetSize:
   spaces: 57868
   telemetry: 51957
   telemetryManagementSection: 38586
-  tileMap: 65337
   timelion: 29920
   transform: 41007
   triggersActionsUi: 100000

src/core/server/ui_settings/saved_objects/migrations.test.ts

@@ -128,3 +128,38 @@ describe('ui_settings 7.13.0 migrations', () => {
     });
   });
 });
+
+describe('ui_settings 8.0.0 migrations', () => {
+  const migration = migrations['8.0.0'];
+
+  test('returns doc on empty object', () => {
+    expect(migration({} as SavedObjectUnsanitizedDoc)).toEqual({
+      references: [],
+    });
+  });
+  test('removes ui_settings from deleted region_map and tile_map plugins', () => {
+    const doc = {
+      type: 'config',
+      id: '8.0.0',
+      attributes: {
+        buildNum: 9007199254740991,
+        'visualization:regionmap:showWarnings': false,
+        'visualization:tileMap:WMSdefaults': '{}',
+        'visualization:tileMap:maxPrecision': 10,
+      },
+      references: [],
+      updated_at: '2020-06-09T20:18:20.349Z',
+      migrationVersion: {},
+    };
+    expect(migration(doc)).toEqual({
+      type: 'config',
+      id: '8.0.0',
+      attributes: {
+        buildNum: 9007199254740991,
+      },
+      references: [],
+      updated_at: '2020-06-09T20:18:20.349Z',
+      migrationVersion: {},
+    });
+  });
+});

src/core/server/ui_settings/saved_objects/migrations.ts

@@ -75,4 +75,27 @@ export const migrations = {
     }),
     references: doc.references || [],
   }),
+  '8.0.0': (doc: SavedObjectUnsanitizedDoc<any>): SavedObjectSanitizedDoc<any> => ({
+    ...doc,
+    ...(doc.attributes && {
+      // owner: Team:Geo
+      attributes: Object.keys(doc.attributes).reduce(
+        (acc, key) =>
+          [
+            'visualization:regionmap:showWarnings',
+            'visualization:tileMap:WMSdefaults',
+            'visualization:tileMap:maxPrecision',
+          ].includes(key)
+            ? {
+                ...acc,
+              }
+            : {
+                ...acc,
+                [key]: doc.attributes[key],
+              },
+        {}
+      ),
+    }),
+    references: doc.references || [],
+  }),
 };