Merge branch 'main' into quick-wins/csp-datatable-row-density

elastic · Aug 22, 2024 · f708e30 · f708e30
2 parents 40174cc + 04916ff
commit f708e30
Show file tree

Hide file tree

Showing 90 changed files with 1,593 additions and 587 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -732,6 +732,7 @@ examples/screenshot_mode_example @elastic/appex-sharedux
 src/plugins/screenshot_mode @elastic/appex-sharedux
 x-pack/examples/screenshotting_example @elastic/appex-sharedux
 x-pack/plugins/screenshotting @elastic/kibana-reporting-services
+packages/kbn-screenshotting-server @elastic/appex-sharedux
 packages/kbn-search-api-panels @elastic/search-kibana
 x-pack/plugins/search_assistant @elastic/search-kibana
 packages/kbn-search-connectors @elastic/search-kibana

diff --git a/docs/user/alerting/alerting-setup.asciidoc b/docs/user/alerting/alerting-setup.asciidoc
@@ -54,12 +54,11 @@ To use {alert-features} in a {kib} app, you must have the appropriate feature pr
 |=== 
 
 | Action | {kib} privileges
-| Give full access to manage alerts, connectors, and rules in *{stack-manage-app}* or *Discover*
+| Give full access to manage alerts, connectors, and rules in *{stack-manage-app}*
 a|
 * `All` for the *Management > {stack-rules-feature}* feature.
 * `All` for the *Management > Rules Settings* feature.
 * `All` for the *Management > {connectors-feature}* feature.
-* `Read` index privileges for the `.alerts-*` system indices
 
 [NOTE]
 ====
@@ -77,12 +76,11 @@ For {observability} rules, you must have `all` privileges for the appropriate {o
 For Security rules, refer to {security-guide}/detections-permissions-section.html[Detections prerequisites and requirements].
 ====
 
-| Give view-only access to alerts, connectors, and rules in  *{stack-manage-app}* or *Discover*
+| Give view-only access to alerts, connectors, and rules in  *{stack-manage-app}*
 a|
 * `Read` for the *Management > {stack-rules-feature}* feature.
 * `Read` for the *Management > Rules Settings* feature.
 * `Read` for the *Management > {connectors-feature}* feature.
-* `Read` index privileges for the `.alerts-*` system indices
 
 [NOTE]
 ====
@@ -93,12 +91,16 @@ For {observability} rules, you must have `read` privileges for the appropriate {
 For Security rules, refer to {security-guide}/detections-permissions-section.html[Detections prerequisites and requirements].
 ====
 
-| Revoke all access to alerts, connectors, and rules in *{stack-manage-app}* or *Discover*
+| Give view-only access to alerts in *Discover* or *Dashboards*
+a|
+* `Read` index privileges for the `.alerts-*` system indices.
+
+| Revoke all access to alerts, connectors, and rules in *{stack-manage-app}*, *Discover*, or *Dashboards*
 a|
 * `None` for the *Management > {stack-rules-feature}* feature.
 * `None` for the *Management > Rules Settings* feature.
 * `None` for the *Management > {connectors-feature}* feature.
-
+* No index privileges for the `.alerts-*` system indices.
 |===
 
 For more information on configuring roles that provide access to features, go to <<kibana-feature-privileges>>.

diff --git a/fleet_packages.json b/fleet_packages.json
@@ -30,7 +30,7 @@
   },
   {
     "name": "elastic_agent",
-    "version": "2.0.2"
+    "version": "2.0.3"
   },
   {
     "name": "endpoint",

diff --git a/package.json b/package.json
@@ -750,6 +750,7 @@
     "@kbn/screenshot-mode-plugin": "link:src/plugins/screenshot_mode",
     "@kbn/screenshotting-example-plugin": "link:x-pack/examples/screenshotting_example",
     "@kbn/screenshotting-plugin": "link:x-pack/plugins/screenshotting",
+    "@kbn/screenshotting-server": "link:packages/kbn-screenshotting-server",
     "@kbn/search-api-panels": "link:packages/kbn-search-api-panels",
     "@kbn/search-assistant": "link:x-pack/plugins/search_assistant",
     "@kbn/search-connectors": "link:packages/kbn-search-connectors",
@@ -971,7 +972,7 @@
     "@langchain/community": "0.2.18",
     "@langchain/core": "^0.2.18",
     "@langchain/google-genai": "^0.0.23",
-    "@langchain/langgraph": "^0.0.31",
+    "@langchain/langgraph": "0.0.34",
     "@langchain/openai": "^0.1.3",
     "@langtrase/trace-attributes": "^3.0.8",
     "@launchdarkly/node-server-sdk": "^9.5.1",

diff --git a/...sql-validation-autocomplete/src/autocomplete/__tests__/autocomplete.command.stats.test.ts b/...sql-validation-autocomplete/src/autocomplete/__tests__/autocomplete.command.stats.test.ts
@@ -137,10 +137,27 @@ describe('autocomplete.suggest', () => {
       test('when typing inside function left paren', async () => {
         const { assertSuggestions } = await setup();
         const expected = [
-          ...getFieldNamesByType([...ESQL_COMMON_NUMERIC_TYPES, 'date', 'boolean', 'ip']),
+          ...getFieldNamesByType([
+            ...ESQL_COMMON_NUMERIC_TYPES,
+            'date',
+            'boolean',
+            'ip',
+            'version',
+            'text',
+            'keyword',
+          ]),
           ...getFunctionSignaturesByReturnType(
             'stats',
-            [...ESQL_COMMON_NUMERIC_TYPES, 'date', 'date_period', 'boolean', 'ip'],
+            [
+              ...ESQL_COMMON_NUMERIC_TYPES,
+              'date',
+              'date_period',
+              'boolean',
+              'ip',
+              'version',
+              'text',
+              'keyword',
+            ],
             {
               scalar: true,
             }

diff --git a/packages/kbn-esql-validation-autocomplete/src/definitions/aggs.ts b/packages/kbn-esql-validation-autocomplete/src/definitions/aggs.ts
@@ -155,6 +155,18 @@ export const statsAggregationFunctionDefinitions: FunctionDefinition[] = [
           params: [{ name: 'column', type: 'ip', noNestingFunctions: true }],
           returnType: 'ip',
         },
+        {
+          params: [{ name: 'column', type: 'version', noNestingFunctions: true }],
+          returnType: 'version',
+        },
+        {
+          params: [{ name: 'column', type: 'keyword', noNestingFunctions: true }],
+          returnType: 'keyword',
+        },
+        {
+          params: [{ name: 'column', type: 'text', noNestingFunctions: true }],
+          returnType: 'text',
+        },
       ],
       examples: [`from index | stats result = max(field)`, `from index | stats max(field)`],
     },
@@ -186,6 +198,18 @@ export const statsAggregationFunctionDefinitions: FunctionDefinition[] = [
           params: [{ name: 'column', type: 'ip', noNestingFunctions: true }],
           returnType: 'ip',
         },
+        {
+          params: [{ name: 'column', type: 'version', noNestingFunctions: true }],
+          returnType: 'version',
+        },
+        {
+          params: [{ name: 'column', type: 'keyword', noNestingFunctions: true }],
+          returnType: 'keyword',
+        },
+        {
+          params: [{ name: 'column', type: 'text', noNestingFunctions: true }],
+          returnType: 'text',
+        },
       ],
       examples: [`from index | stats result = min(field)`, `from index | stats min(field)`],
     },

diff --git a/packages/kbn-esql-validation-autocomplete/src/definitions/functions.ts b/packages/kbn-esql-validation-autocomplete/src/definitions/functions.ts
@@ -4145,6 +4145,160 @@ const mvMinDefinition: FunctionDefinition = {
   ],
 };
 
+// Do not edit this manually... generated by scripts/generate_function_definitions.ts
+const mvPercentileDefinition: FunctionDefinition = {
+  type: 'eval',
+  name: 'mv_percentile',
+  description: i18n.translate('kbn-esql-validation-autocomplete.esql.definitions.mv_percentile', {
+    defaultMessage:
+      'Converts a multivalued field into a single valued field containing the value at which a certain percentage of observed values occur.',
+  }),
+  alias: undefined,
+  signatures: [
+    {
+      params: [
+        {
+          name: 'number',
+          type: 'double',
+          optional: false,
+        },
+        {
+          name: 'percentile',
+          type: 'double',
+          optional: false,
+        },
+      ],
+      returnType: 'double',
+    },
+    {
+      params: [
+        {
+          name: 'number',
+          type: 'double',
+          optional: false,
+        },
+        {
+          name: 'percentile',
+          type: 'integer',
+          optional: false,
+        },
+      ],
+      returnType: 'double',
+    },
+    {
+      params: [
+        {
+          name: 'number',
+          type: 'double',
+          optional: false,
+        },
+        {
+          name: 'percentile',
+          type: 'long',
+          optional: false,
+        },
+      ],
+      returnType: 'double',
+    },
+    {
+      params: [
+        {
+          name: 'number',
+          type: 'integer',
+          optional: false,
+        },
+        {
+          name: 'percentile',
+          type: 'double',
+          optional: false,
+        },
+      ],
+      returnType: 'integer',
+    },
+    {
+      params: [
+        {
+          name: 'number',
+          type: 'integer',
+          optional: false,
+        },
+        {
+          name: 'percentile',
+          type: 'integer',
+          optional: false,
+        },
+      ],
+      returnType: 'integer',
+    },
+    {
+      params: [
+        {
+          name: 'number',
+          type: 'integer',
+          optional: false,
+        },
+        {
+          name: 'percentile',
+          type: 'long',
+          optional: false,
+        },
+      ],
+      returnType: 'integer',
+    },
+    {
+      params: [
+        {
+          name: 'number',
+          type: 'long',
+          optional: false,
+        },
+        {
+          name: 'percentile',
+          type: 'double',
+          optional: false,
+        },
+      ],
+      returnType: 'long',
+    },
+    {
+      params: [
+        {
+          name: 'number',
+          type: 'long',
+          optional: false,
+        },
+        {
+          name: 'percentile',
+          type: 'integer',
+          optional: false,
+        },
+      ],
+      returnType: 'long',
+    },
+    {
+      params: [
+        {
+          name: 'number',
+          type: 'long',
+          optional: false,
+        },
+        {
+          name: 'percentile',
+          type: 'long',
+          optional: false,
+        },
+      ],
+      returnType: 'long',
+    },
+  ],
+  supportedCommands: ['stats', 'inlinestats', 'metrics', 'eval', 'where', 'row', 'sort'],
+  supportedOptions: ['by'],
+  validate: undefined,
+  examples: [
+    'ROW values = [5, 5, 10, 12, 5000]\n| EVAL p50 = MV_PERCENTILE(values, 50), median = MV_MEDIAN(values)',
+  ],
+};
+
 // Do not edit this manually... generated by scripts/generate_function_definitions.ts
 const mvPseriesWeightedSumDefinition: FunctionDefinition = {
   type: 'eval',
@@ -8323,6 +8477,7 @@ export const evalFunctionDefinitions = [
   mvMaxDefinition,
   mvMedianDefinition,
   mvMinDefinition,
+  mvPercentileDefinition,
   mvPseriesWeightedSumDefinition,
   mvSliceDefinition,
   mvSortDefinition,