[Security Solution] Remove Landing Pages sub-plugin (#157957)

## Summary

This is a code cleaning to prepare for
#157847

This PR removes the Landing Pages sub-plugin without introducing any
noticeable change in the UX.
All the logic of the Landing Pages sub-plugin has been relocated to the
proper Explore and Management sub-plugins.
The Dashboard sub-plugin landing page was also relocated in a previous
PR.

The common components used by the different landing page components
(`LandingLinksIcons` and `LandingLinksImages`) have been relocated to
_public/common/components/landing_links/*_.

### Benefits

Cleaning of a non-necessary sub-plugin.

Each Security sub-team will now own its landing page component, route,
and link configuration.

More consistent directory organization, and less complexity.

x-pack/plugins/security_solution/public/landing_pages/components/landing_links_icons.test.tsx → x-pack/plugins/security_solution/public/common/components/landing_links/landing_links_icons.test.tsx

@@ -7,11 +7,11 @@
 
 import { render } from '@testing-library/react';
 import React from 'react';
-import { SecurityPageName } from '../../app/types';
-import type { NavLinkItem } from '../../common/components/navigation/types';
-import { TestProviders } from '../../common/mock';
+import { SecurityPageName } from '../../../app/types';
+import type { NavLinkItem } from '../navigation/types';
+import { TestProviders } from '../../mock';
 import { LandingLinksIcons } from './landing_links_icons';
-import * as telemetry from '../../common/lib/telemetry';
+import * as telemetry from '../../lib/telemetry';
 
 const DEFAULT_NAV_ITEM: NavLinkItem = {
   id: SecurityPageName.overview,
@@ -22,8 +22,8 @@ const DEFAULT_NAV_ITEM: NavLinkItem = {
 const spyTrack = jest.spyOn(telemetry, 'track');
 
 const mockNavigateTo = jest.fn();
-jest.mock('../../common/lib/kibana', () => {
-  const originalModule = jest.requireActual('../../common/lib/kibana');
+jest.mock('../../lib/kibana', () => {
+  const originalModule = jest.requireActual('../../lib/kibana');
   return {
     ...originalModule,
     useNavigateTo: () => ({
@@ -32,8 +32,8 @@ jest.mock('../../common/lib/kibana', () => {
   };
 });
 
-jest.mock('../../common/components/link_to', () => {
-  const originalModule = jest.requireActual('../../common/components/link_to');
+jest.mock('../link_to', () => {
+  const originalModule = jest.requireActual('../link_to');
   return {
     ...originalModule,
     useGetSecuritySolutionUrl: () =>

x-pack/plugins/security_solution/public/landing_pages/components/landing_links_icons.tsx → x-pack/plugins/security_solution/public/common/components/landing_links/landing_links_icons.tsx

@@ -8,13 +8,10 @@ import { EuiFlexGrid, EuiFlexGroup, EuiFlexItem, EuiIcon, EuiText, EuiTitle } fr
 import React from 'react';
 import styled from 'styled-components';
 
-import { NavItemBetaBadge } from '../../common/components/navigation/nav_item_beta_badge';
-import {
-  SecuritySolutionLinkAnchor,
-  withSecuritySolutionLink,
-} from '../../common/components/links';
-import type { NavLinkItem } from '../../common/components/navigation/types';
-import { METRIC_TYPE, TELEMETRY_EVENT, track } from '../../common/lib/telemetry';
+import { NavItemBetaBadge } from '../navigation/nav_item_beta_badge';
+import { SecuritySolutionLinkAnchor, withSecuritySolutionLink } from '../links';
+import type { NavLinkItem } from '../navigation/types';
+import { METRIC_TYPE, TELEMETRY_EVENT, track } from '../../lib/telemetry';
 
 interface LandingLinksImagesProps {
   items: NavLinkItem[];

x-pack/plugins/security_solution/public/landing_pages/components/landing_links_images.test.tsx → x-pack/plugins/security_solution/public/common/components/landing_links/landing_links_images.test.tsx

@@ -8,11 +8,11 @@
 import { render } from '@testing-library/react';
 import React from 'react';
 import { BETA } from '@kbn/kubernetes-security-plugin/common/translations';
-import { SecurityPageName } from '../../app/types';
-import type { NavLinkItem } from '../../common/components/navigation/types';
-import { TestProviders } from '../../common/mock';
+import { SecurityPageName } from '../../../app/types';
+import type { NavLinkItem } from '../navigation/types';
+import { TestProviders } from '../../mock';
 import { LandingLinksImages, LandingImageCards } from './landing_links_images';
-import * as telemetry from '../../common/lib/telemetry';
+import * as telemetry from '../../lib/telemetry';
 
 const DEFAULT_NAV_ITEM: NavLinkItem = {
   id: SecurityPageName.overview,
@@ -29,7 +29,7 @@ const BETA_NAV_ITEM: NavLinkItem = {
   isBeta: true,
 };
 
-jest.mock('../../common/lib/kibana/kibana_react', () => {
+jest.mock('../../lib/kibana/kibana_react', () => {
   return {
     useKibana: jest.fn().mockReturnValue({
       services: {

x-pack/plugins/security_solution/public/landing_pages/components/landing_links_images.tsx → x-pack/plugins/security_solution/public/common/components/landing_links/landing_links_images.tsx

@@ -16,10 +16,10 @@ import {
 import { METRIC_TYPE } from '@kbn/analytics';
 import React from 'react';
 import styled from 'styled-components';
-import { withSecuritySolutionLink } from '../../common/components/links';
-import { NavItemBetaBadge } from '../../common/components/navigation/nav_item_beta_badge';
-import type { NavLinkItem } from '../../common/components/navigation/types';
-import { TELEMETRY_EVENT, track } from '../../common/lib/telemetry';
+import { withSecuritySolutionLink } from '../links';
+import { NavItemBetaBadge } from '../navigation/nav_item_beta_badge';
+import type { NavLinkItem } from '../navigation/types';
+import { TELEMETRY_EVENT, track } from '../../lib/telemetry';
 
 interface LandingImagesProps {
   items: NavLinkItem[];

x-pack/plugins/security_solution/public/common/links/app_links.ts

@@ -11,7 +11,7 @@ import { links as detectionLinks } from '../../detections/links';
 import { links as timelinesLinks } from '../../timelines/links';
 import { getCasesLinkItems } from '../../cases/links';
 import { links as managementLinks, getManagementFilteredLinks } from '../../management/links';
-import { threatHuntingLandingLinks } from '../../landing_pages/links';
+import { exploreLinks } from '../../explore/links';
 import { gettingStartedLinks } from '../../overview/links';
 import { rootLinks as cloudSecurityPostureRootLinks } from '../../cloud_security_posture/links';
 import type { StartPlugins } from '../../types';
@@ -25,10 +25,10 @@ export const links = Object.freeze([
   cloudSecurityPostureRootLinks,
   timelinesLinks,
   casesLinks,
-  threatHuntingLandingLinks,
+  exploreLinks,
+  indicatorsLinks,
   gettingStartedLinks,
   managementLinks,
-  indicatorsLinks,
 ]);
 
 export const getFilteredLinks = async (
@@ -43,9 +43,9 @@ export const getFilteredLinks = async (
     cloudSecurityPostureRootLinks,
     timelinesLinks,
     casesLinks,
-    threatHuntingLandingLinks,
+    exploreLinks,
+    indicatorsLinks,
     gettingStartedLinks,
     managementFilteredLinks,
-    indicatorsLinks,
   ]);
 };

x-pack/plugins/security_solution/public/dashboards/pages/landing_page/index.tsx

@@ -10,7 +10,7 @@ import type { DashboardCapabilities } from '@kbn/dashboard-plugin/common/types';
 import { LEGACY_DASHBOARD_APP_ID } from '@kbn/dashboard-plugin/public';
 import { SecuritySolutionPageWrapper } from '../../../common/components/page_wrapper';
 import { SpyRoute } from '../../../common/utils/route/spy_routes';
-import { LandingImageCards } from '../../../landing_pages/components/landing_links_images';
+import { LandingImageCards } from '../../../common/components/landing_links/landing_links_images';
 import { SecurityPageName } from '../../../../common/constants';
 import { useCapabilities, useNavigateTo } from '../../../common/lib/kibana';
 import { useRootNavLink } from '../../../common/links/nav_links';

x-pack/plugins/security_solution/public/landing_pages/pages/explore.tsx → x-pack/plugins/security_solution/public/explore/landing.tsx

@@ -5,13 +5,17 @@
  * 2.0.
  */
 import React from 'react';
-import { SecurityPageName } from '../../app/types';
-import { HeaderPage } from '../../common/components/header_page';
-import { useRootNavLink } from '../../common/links/nav_links';
-import { SecuritySolutionPageWrapper } from '../../common/components/page_wrapper';
-import { SpyRoute } from '../../common/utils/route/spy_routes';
-import { LandingLinksImages } from '../components/landing_links_images';
-import { EXPLORE_PAGE_TITLE } from './translations';
+import { i18n } from '@kbn/i18n';
+import { SecurityPageName } from '../app/types';
+import { HeaderPage } from '../common/components/header_page';
+import { useRootNavLink } from '../common/links/nav_links';
+import { SecuritySolutionPageWrapper } from '../common/components/page_wrapper';
+import { SpyRoute } from '../common/utils/route/spy_routes';
+import { LandingLinksImages } from '../common/components/landing_links/landing_links_images';
+
+const EXPLORE_PAGE_TITLE = i18n.translate('xpack.securitySolution.explore.landing.pageTitle', {
+  defaultMessage: 'Explore',
+});
 
 export const ExploreLandingPage = () => {
   const exploreLinks = useRootNavLink(SecurityPageName.exploreLanding)?.links ?? [];

x-pack/plugins/security_solution/public/explore/links.ts

@@ -6,8 +6,15 @@
  */
 
 import { i18n } from '@kbn/i18n';
-import { HOSTS_PATH, NETWORK_PATH, SecurityPageName, USERS_PATH } from '../../common/constants';
-import { HOSTS, NETWORK, USERS } from '../app/translations';
+import {
+  HOSTS_PATH,
+  NETWORK_PATH,
+  USERS_PATH,
+  EXPLORE_PATH,
+  SERVER_APP_ID,
+  SecurityPageName,
+} from '../../common/constants';
+import { EXPLORE, HOSTS, NETWORK, USERS } from '../app/translations';
 import type { LinkItem } from '../common/links/types';
 import hostsPageImg from '../common/images/hosts_page.png';
 import userPageImg from '../common/images/users_page.png';
@@ -169,4 +176,17 @@ const hostsLinks: LinkItem = {
   ],
 };
 
-export const exploreLinks = [hostsLinks, networkLinks, usersLinks];
+export const exploreLinks: LinkItem = {
+  id: SecurityPageName.exploreLanding,
+  title: EXPLORE,
+  path: EXPLORE_PATH,
+  globalNavPosition: 6,
+  capabilities: [`${SERVER_APP_ID}.show`],
+  globalSearchKeywords: [
+    i18n.translate('xpack.securitySolution.appLinks.explore', {
+      defaultMessage: 'Explore',
+    }),
+  ],
+  links: [hostsLinks, networkLinks, usersLinks],
+  skipUrlState: true,
+};

x-pack/plugins/security_solution/public/explore/routes.tsx

@@ -13,8 +13,17 @@ import { NetworkContainer } from './network/pages';
 
 import type { SecuritySubPluginRoutes } from '../app/types';
 import { SecurityPageName } from '../app/types';
-import { HOSTS_PATH, NETWORK_PATH, USERS_PATH } from '../../common/constants';
+import { EXPLORE_PATH, HOSTS_PATH, NETWORK_PATH, USERS_PATH } from '../../common/constants';
 import { PluginTemplateWrapper } from '../common/components/plugin_template_wrapper';
+import { ExploreLandingPage } from './landing';
+
+const ExploreLanding = () => (
+  <PluginTemplateWrapper>
+    <TrackApplicationView viewId={SecurityPageName.exploreLanding}>
+      <ExploreLandingPage />
+    </TrackApplicationView>
+  </PluginTemplateWrapper>
+);
 
 const NetworkRoutes = () => (
   <PluginTemplateWrapper>
@@ -41,6 +50,11 @@ const HostsRoutes = () => (
 );
 
 export const routes: SecuritySubPluginRoutes = [
+  {
+    path: EXPLORE_PATH,
+    exact: true,
+    component: ExploreLanding,
+  },
   {
     path: NETWORK_PATH,
     component: NetworkRoutes,

x-pack/plugins/security_solution/public/lazy_sub_plugins.tsx

@@ -19,7 +19,6 @@ import { Overview } from './overview';
 import { Rules } from './rules';
 import { Timelines } from './timelines';
 import { Management } from './management';
-import { LandingPages } from './landing_pages';
 import { CloudDefend } from './cloud_defend';
 import { CloudSecurityPosture } from './cloud_security_posture';
 import { ThreatIntelligence } from './threat_intelligence';
@@ -38,7 +37,6 @@ const subPluginClasses = {
   Rules,
   Timelines,
   Management,
-  LandingPages,
   Dashboards,
   CloudDefend,
   CloudSecurityPosture,

x-pack/plugins/security_solution/public/landing_pages/pages/manage.test.tsx → x-pack/plugins/security_solution/public/management/pages/landing.test.tsx

@@ -9,7 +9,7 @@ import { render } from '@testing-library/react';
 import React from 'react';
 import { SecurityPageName } from '../../app/types';
 import { TestProviders } from '../../common/mock';
-import { ManagementCategories } from './manage';
+import { ManagementCategories } from './landing';
 import type { NavigationLink } from '../../common/links';
 
 const RULES_ITEM_LABEL = 'elastic rules!';