[Fleet] Hide the custom mapping/pipeline block for custom log integration #144696
Assignees
Labels
Team:Fleet
Team label for Observability Data Collection Fleet team
Comments
nchaulet
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
@nimarezainia What is your opinion on this? |
|
We should hide these UIs for any |
hop-dev
added a commit
that referenced
this issue
Feb 24, 2023
…ws dataset to be configured (#152086) Closes #144696 For packages which allow dataset to be configured (e.g custom logs, custom http) do not show the pipeline and mappings editor when editing a package policy. This is because the pipelines are only set up at install time so will not match the datastream if the user elects to change it. Bonus change: I have moved the `data_stream.dataset` var to a constant as we use it in a lot of places <img width="1265" alt="Screenshot 2023-02-24 at 12 12 19" src="https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png">
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Feb 24, 2023
…ws dataset to be configured (elastic#152086) Closes elastic#144696 For packages which allow dataset to be configured (e.g custom logs, custom http) do not show the pipeline and mappings editor when editing a package policy. This is because the pipelines are only set up at install time so will not match the datastream if the user elects to change it. Bonus change: I have moved the `data_stream.dataset` var to a constant as we use it in a lot of places <img width="1265" alt="Screenshot 2023-02-24 at 12 12 19" src="https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png"> (cherry picked from commit db1c79a)
kibanamachine
added a commit
that referenced
this issue
Feb 24, 2023
…n allows dataset to be configured (#152086) (#152101) # Backport This will backport the following commits from `main` to `8.7`: - [[Fleet] Do not show mappings and pipelines editor if integration allows dataset to be configured (#152086)](#152086) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-24T14:00:28Z","message":"[Fleet] Do not show mappings and pipelines editor if integration allows dataset to be configured (#152086)\n\nCloses #144696\r\n\r\nFor packages which allow dataset to be configured (e.g custom logs,\r\ncustom http) do not show the pipeline and mappings editor when editing a\r\npackage policy. This is because the pipelines are only set up at install\r\ntime so will not match the datastream if the user elects to change it.\r\n\r\nBonus change: I have moved the `data_stream.dataset` var to a constant\r\nas we use it in a lot of places\r\n\r\n<img width=\"1265\" alt=\"Screenshot 2023-02-24 at 12 12 19\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png\">","sha":"db1c79a70d16362317e58f2d58c5a1779510eb1e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v8.7.0","v8.8.0"],"number":152086,"url":"https://github.com/elastic/kibana/pull/152086","mergeCommit":{"message":"[Fleet] Do not show mappings and pipelines editor if integration allows dataset to be configured (#152086)\n\nCloses #144696\r\n\r\nFor packages which allow dataset to be configured (e.g custom logs,\r\ncustom http) do not show the pipeline and mappings editor when editing a\r\npackage policy. This is because the pipelines are only set up at install\r\ntime so will not match the datastream if the user elects to change it.\r\n\r\nBonus change: I have moved the `data_stream.dataset` var to a constant\r\nas we use it in a lot of places\r\n\r\n<img width=\"1265\" alt=\"Screenshot 2023-02-24 at 12 12 19\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png\">","sha":"db1c79a70d16362317e58f2d58c5a1779510eb1e"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152086","number":152086,"mergeCommit":{"message":"[Fleet] Do not show mappings and pipelines editor if integration allows dataset to be configured (#152086)\n\nCloses #144696\r\n\r\nFor packages which allow dataset to be configured (e.g custom logs,\r\ncustom http) do not show the pipeline and mappings editor when editing a\r\npackage policy. This is because the pipelines are only set up at install\r\ntime so will not match the datastream if the user elects to change it.\r\n\r\nBonus change: I have moved the `data_stream.dataset` var to a constant\r\nas we use it in a lot of places\r\n\r\n<img width=\"1265\" alt=\"Screenshot 2023-02-24 at 12 12 19\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png\">","sha":"db1c79a70d16362317e58f2d58c5a1779510eb1e"}}]}] BACKPORT--> Co-authored-by: Mark Hopkin <[email protected]>
![https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png\">","sha":"db1c79a70d16362317e58f2d58c5a1779510eb1e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v8.7.0","v8.8.0"],"number":152086,"url":"https://github.com/elastic/kibana/pull/152086","mergeCommit":{"message":"[Fleet]](https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png\">","sha":"db1c79a70d16362317e58f2d58c5a1779510eb1e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v8.7.0","v8.8.0"],"number":152086,"url":"https://github.com/elastic/kibana/pull/152086","mergeCommit":{"message":"[Fleet]){kind=link}
![https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png\">","sha":"db1c79a70d16362317e58f2d58c5a1779510eb1e"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152086","number":152086,"mergeCommit":{"message":"[Fleet]](https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png\">","sha":"db1c79a70d16362317e58f2d58c5a1779510eb1e"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152086","number":152086,"mergeCommit":{"message":"[Fleet]){kind=link}
![https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png\">","sha":"db1c79a70d16362317e58f2d58c5a1779510eb1e](https://user-images.githubusercontent.com/3315046/221176407-ab26b755-8cf4-4e4a-8ee3-83f947cfd4cb.png\">","sha":"db1c79a70d16362317e58f2d58c5a1779510eb1e){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The custom integrations, that allow the user to specify a dataset are not compatible with the
@custommapping and pipeline feature we built.We should probably hide the block from the package policy editor here. (we should probably update the doc too)/
The text was updated successfully, but these errors were encountered: