Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Change point detection enhancements #145703

Closed
12 tasks done
peteharverson opened this issue Nov 18, 2022 · 1 comment · Fixed by #151022
Closed
12 tasks done

[ML] Change point detection enhancements #145703

peteharverson opened this issue Nov 18, 2022 · 1 comment · Fixed by #151022
Assignees
@darnautov
Labels
enhancement New value added to drive a business result Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml Team:ML Team label for ML (also use :ml) v8.7.0

Comments

@peteharverson
Copy link
Contributor

peteharverson commented Nov 18, 2022 •
edited by darnautov
Loading

Follow-up enhancements to work in #144093

Must:

  • Filter out the stationary and non_stationary items, and instead show a 'No significant change points detected` if there are no significant deviations?
  • Increase precision used for p-value formatting to 3 sigfigs (be consistent with the log rate spikes page).
  • Add filter by change point type
  • Need to be able to configure the y-axis range as using min of 0 is not always helpful
  • Add a link to the change point detection docs
  • Increase the width of inputs for the metric field and split field:

image

  • Show a callout if a non-time based index is selected as we use on the Log Rate Spikes page

image

  • Show callout or prevent selection of data views with no numeric fields

  • Hide the split field control for data views with no keyword / IP fields and support finding change points in series which just have a function and metric field

  • Check if we should allow IP fields to be used as the split field

  • When clicking to the right of the controls after an analysis has run, the progress bar appears (this might be with very large data sets - 14.5M docs here, which take a very long time to run)
    change_point_progress_bar

  • Improve handling for long-running requests against high cardinality series.

Originally posted by @peteharverson in #144093 (comment)
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson added v8.7.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis enhancement New value added to drive a business result Team:ML Team label for ML (also use :ml) labels Nov 18, 2022
@darnautov darnautov mentioned this issue Feb 6, 2023
Merged
7 tasks
darnautov added a commit that referenced this issue Feb 7, 2023
@darnautov
[ML] Adds change point detection feature (#150308)
c8b75b3 
## Summary

Part of #145703, adding enhancements to the new Change Point Detection
page for technical preview under the AIOps Labs section in the ML
plugin.

<img width="1406" alt="image"
src="https://user-images.githubusercontent.com/5236598/217035513-86325cd9-17a9-46ed-8aea-77585038a427.png">

- Use the data bounds mode for the Y-axis 
- Add a cardinality check for the split field with a hard limit of
10,000
-  Show series labels above charts 
- Replace fields `select` controls with the `EuiComboBox`
- Add a filter for change point type 
- Display aggregation interval 
- Add a docs link to the Change Point Aggregation 
- Make split field optional 

### Checklist


- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@darnautov darnautov mentioned this issue Feb 13, 2023
Merged
darnautov added a commit that referenced this issue Feb 14, 2023
@darnautov
[ML] Allow splitting by field of ip type for Change point detection (…
12efa35 
…#151022)

## Summary

Follow-up for #150308

Resolves #145703

Allows splitting by field of `ip` type for Change point detection
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 14, 2023
@darnautov
[ML] Allow splitting by field of ip type for Change point detection (…
7c1a4ff 
…elastic#151022)

## Summary

Follow-up for elastic#150308

Resolves elastic#145703

Allows splitting by field of `ip` type for Change point detection

(cherry picked from commit 12efa35)
kibanamachine referenced this issue Feb 14, 2023
@kibanamachine @darnautov
[8.7] [ML] Allow splitting by field of ip type for Change point det…
238244e 
…ection (#151022) (#151144)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[ML] Allow splitting by field of `ip` type for Change point detection
(#151022)](#151022)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-14T14:33:55Z","message":"[ML]
Allow splitting by field of `ip` type for Change point detection
(#151022)\n\n## Summary\r\n\r\nFollow-up for
https://github.com/elastic/kibana/pull/150308\r\n\r\nResolves
https://github.com/elastic/kibana/issues/145703\r\n\r\nAllows splitting
by field of `ip` type for Change point
detection","sha":"12efa3584743e67fc474dc57edbbb6d2b6182b5a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Team:ML","Feature:ML/AIOps","v8.7.0","v8.8.0"],"number":151022,"url":"https://github.com/elastic/kibana/pull/151022","mergeCommit":{"message":"[ML]
Allow splitting by field of `ip` type for Change point detection
(#151022)\n\n## Summary\r\n\r\nFollow-up for
https://github.com/elastic/kibana/pull/150308\r\n\r\nResolves
https://github.com/elastic/kibana/issues/145703\r\n\r\nAllows splitting
by field of `ip` type for Change point
detection","sha":"12efa3584743e67fc474dc57edbbb6d2b6182b5a"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151022","number":151022,"mergeCommit":{"message":"[ML]
Allow splitting by field of `ip` type for Change point detection
(#151022)\n\n## Summary\r\n\r\nFollow-up for
https://github.com/elastic/kibana/pull/150308\r\n\r\nResolves
https://github.com/elastic/kibana/issues/145703\r\n\r\nAllows splitting
by field of `ip` type for Change point
detection","sha":"12efa3584743e67fc474dc57edbbb6d2b6182b5a"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
@darnautov darnautov mentioned this issue Feb 20, 2023
Closed
6 tasks
justinkambic pushed a commit to justinkambic/kibana that referenced this issue Feb 23, 2023
@darnautov @justinkambic
[ML] Allow splitting by field of ip type for Change point detection (…
312664c 
…elastic#151022)

## Summary

Follow-up for elastic#150308

Resolves elastic#145703

Allows splitting by field of `ip` type for Change point detection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darnautov darnautov

Labels
enhancement New value added to drive a business result Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml Team:ML Team label for ML (also use :ml) v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Allow splitting by field of ip type for Change point detection darnautov/kibana
3 participants
@darnautov @peteharverson @elasticmachine