Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSDB] [Field list] Show min max for counter fields #155510

Closed
stratoula opened this issue Apr 21, 2023 · 2 comments · Fixed by #155499
Closed

[TSDB] [Field list] Show min max for counter fields #155510

stratoula opened this issue Apr 21, 2023 · 2 comments · Fixed by #155499
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:Lens Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

Describe the feature:
In 8.8 we added support for counter fields but as they dont support all aggregations the analysis that appears when you click the field on the list doesnt appear.

image

We decided to improve this by displaying the min/max range instead
@stratoula stratoula added Feature:Discover Discover Application enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Apr 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@stratoula stratoula mentioned this issue Apr 21, 2023
Closed
@jughosta jughosta mentioned this issue Apr 21, 2023
Merged
4 tasks
@jughosta jughosta self-assigned this Apr 21, 2023
@davismcphee davismcphee added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Apr 21, 2023
@lalit-satapathy lalit-satapathy mentioned this issue Apr 21, 2023
Closed
45 tasks
jughosta added a commit that referenced this issue May 8, 2023
@jughosta
[TSDB][UnifiedFieldList] Show counter min/max values in field popover (…
baa94a3 
…#155499)

Addresses #155510

## Summary

This PR shows min and max values of time series counter field in the
field popover.

Before:
<img width="400" alt="Screenshot 2023-04-21 at 13 26 37"
src="https://user-images.githubusercontent.com/1415710/233624673-fc07a6b0-7e14-4936-aa7b-0d177f395fef.png">

After:
<img width="500" alt="Screenshot 2023-04-21 at 13 22 50"
src="https://user-images.githubusercontent.com/1415710/233624506-d6b0a3f7-23bb-4178-a01a-ae78e664cd9d.png">



### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@jughosta jughosta linked a pull request May 10, 2023 that will close this issue
[TSDB][UnifiedFieldList] Show counter min/max values in field popover #155499
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:Lens Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSDB][UnifiedFieldList] Show counter min/max values in field popover jughosta/kibana
4 participants
@jughosta @elasticmachine @stratoula @davismcphee