Limit the target_app setting to serverless deployments #157042
Assignees
Labels
Feature:Logs UI
Logs UI feature
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Comments
jsanz
added
the
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
tonyghiani
added a commit
that referenced
this issue
May 31, 2023
## 📓 Summary Closes #157042 After the implementation of #156837, we are now able to limit the `logs.app_target` configuration to be accepted only in a serverless environment, otherwise, it'll not be accepted. Since we still need to use a default fallback value for the logs UI app, the fallback will be applied internally when looking for this config, to keep the original behaviour unchanged. ## 🧪 Testing ### Serverless environment - Start Elasticsearch with `yarn es snapshot` and Kibana with `yarn serverless-oblt` - Verify that when navigating to Logs pages through the sidebar links or directly accessing the url `/app/logs` it redirects to discover. ### Normal environment - Start Elasticsearch with `yarn es snapshot` and Kibana with `yarn start` - Verify that when navigating to Logs pages through the sidebar links or directly accessing the url `/app/logs` the log stream is rendered correctly. ### Limited to serverless env To verify that the configuration is only accepted under a serverless context, set into your kibana.yml or `kibana.dev.yml` the configuration ```yml xpack.infra.logs.app_target: discover ``` and verify that it triggers a validation error when running Kibana. --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
📓 Summary
With #154145 we introduced the setting
xpack.infra.logs.app_targetto theinfraplugin's config schema. Now that #156837 is available we should limit it to the serverless deployment type so it's not abused in other deployment scenarios.✔️ Acceptance criteria
xpack.infra.logs.app_targetto theinfraplugin's config schema is scoped to theserverlessdeployment type using the mechanism provided by [Config Service] ExposeserverlesscontextRef #156837.The text was updated successfully, but these errors were encountered: