Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataViews] public routes must satsify bwca #157099

Closed
5 tasks done
thomasneirynck opened this issue May 8, 2023 · 1 comment · Fixed by #158608
Closed
5 tasks done

[DataViews] public routes must satsify bwca #157099

thomasneirynck opened this issue May 8, 2023 · 1 comment · Fixed by #158608
Assignees
@mattkime
Labels
chore impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented May 8, 2023 •
edited by davismcphee
Loading

Public routes must be backward compliant

  • /api/data_views
  • /api/data_views/data_view
  • /api/data_views/data_view/**
  • /api/data_views/default
  • /api/data_views/has_user_data_view

Public documentation here https://www.elastic.co/guide/en/kibana/master/data-views-api.html

Part of #157046
@botelastic botelastic bot added the needs-team Issues missing a team label label May 8, 2023
@thomasneirynck thomasneirynck added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed needs-team Issues missing a team label labels May 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime self-assigned this May 10, 2023
@lukasolson lukasolson added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels May 25, 2023
@mattkime mattkime mentioned this issue May 28, 2023
Merged
mattkime added a commit that referenced this issue Jun 13, 2023
@mattkime @jughosta
[data views] Use versioned router for REST routes (#158608)
26d4ba5 
## Summary

Version alllll the data view routes.

Best viewed with whitespace hidden -
https://github.com/elastic/kibana/pull/158608/files?diff=unified&w=1

In this PR:
- All REST (public and internal) routes are versioned
- Internal routes are called with version specified
- Internal and public routes are now stored in directories labeled as
such
- All routes have a response schema
- All responses are typed with `response` types, separate from internal
api types. This is to help prevent unacknowledged changes to the api.
- Moves some functional tests from js => ts

For follow up PRs:
- Move to `internal` path for internal routes
- Proper typing and schema for `fields_for_wildcard` filter

Closes #157099
Closes #157100

---------

Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
chore impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[data views] Use versioned router for REST routes mattkime/kibana
4 participants
@mattkime @lukasolson @thomasneirynck @elasticmachine