Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Use new fields locations in CNVM findings #157674

Closed
uri-weisman opened this issue May 15, 2023 · 2 comments · Fixed by #164651
Closed

[Cloud Security] Use new fields locations in CNVM findings #157674

uri-weisman opened this issue May 15, 2023 · 2 comments · Fixed by #164651
Assignees
@mitodrummer
Labels
8.11 candidate good first issue low hanging fruit Team:Cloud Security Cloud Security team related technical debt Improvement of the software architecture and operational architecture Vulnerability Management

Comments

@uri-weisman
Copy link
Contributor

uri-weisman commented May 15, 2023 •
edited by kfirpeled
Loading

In order to conform to ECS, we have made changes to certain fields. Our objective is to use the new fields while still maintaining support for the previous version's schema for BC.

  1. Replace the usages of vulnerability.package to use package.* (findings schema possess both fields as of 8.8)

Related:

Out of scope:
@uri-weisman uri-weisman added Team:Cloud Security Cloud Security team related 8.9 candidate labels May 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@uri-weisman uri-weisman mentioned this issue May 15, 2023
Closed
4 tasks
@kfirpeled kfirpeled added technical debt Improvement of the software architecture and operational architecture Vulnerability Management labels May 19, 2023
@tehilashn tehilashn added the good first issue low hanging fruit label Jul 17, 2023
@mitodrummer mitodrummer self-assigned this Jul 31, 2023
@kfirpeled
Copy link
Contributor

Changed release candidate for this one - moved to 8.11.
It is not necessary for 8.10 and we are in a tight schedule already

cc: @mitodrummer , @uri-weisman

@mitodrummer mitodrummer mentioned this issue Aug 23, 2023
Merged
2 tasks
@mitodrummer mitodrummer linked a pull request Aug 23, 2023 that will close this issue
[Cloud Security] updates to move from doc_root.vulnerability.package -> doc_root.package (ECS) #164651
Merged
2 tasks
mitodrummer added a commit that referenced this issue Aug 24, 2023
@mitodrummer @kibanamachine
[Cloud Security] updates to move from doc_root.vulnerability.package …
fda98b0 
…-> doc_root.package (ECS) (#164651)

## Summary

Issue: #157674

This updates all instances of vulnerability.package to the ECS standard
package fieldset.

The new field has been populated by cloudbeat since 8.8

### Checklist

Delete any items that are not applicable to this PR.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitodrummer mitodrummer

Labels
8.11 candidate good first issue low hanging fruit Team:Cloud Security Cloud Security team related technical debt Improvement of the software architecture and operational architecture Vulnerability Management
Projects
None yet
Milestone
No milestone
5 participants
@elasticmachine @mitodrummer @kfirpeled @uri-weisman @tehilashn