Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] proxy configuration should allow a socks5-prefixed proxy url since Agent supports socks5 proxies #158659

Closed
bczifra opened this issue May 30, 2023 · 1 comment · Fixed by #174338
Closed

[Fleet] proxy configuration should allow a socks5-prefixed proxy url since Agent supports socks5 proxies #158659

bczifra opened this issue May 30, 2023 · 1 comment · Fixed by #174338
Labels
bug Fixes for quality problems that affect the customer experience Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@bczifra
Copy link
Member

bczifra commented May 30, 2023 •
edited
Loading

Expected behavior:
Per https://www.elastic.co/guide/en/fleet/current/fleet-agent-proxy-support.html Elastic Agent supports Socks5 proxies, but the validation in

kibana/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/edit_fleet_proxy_flyout/user_fleet_proxy_form.tsx

Line 24 in 94d4574

const URL_REGEX = /^(http)(s)?:\/\/[^\s$.?#].[^\s]*$/gm;
demands either an http or https scheme, so there is no way to specify a socks5://-prefixed proxy url in the Fleet UI.

Screenshots (if relevant):
socks5_error
@bczifra bczifra added bug Fixes for quality problems that affect the customer experience Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team labels May 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet changed the title Fleet's proxy configuration should allow a socks5-prefixed proxy url since Agent supports socks5 proxies [Fleet] proxy configuration should allow a socks5-prefixed proxy url since Agent supports socks5 proxies May 30, 2023
@jlind23 jlind23 mentioned this issue Jan 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Accept socks5 proxy url nchaulet/kibana
2 participants
@elasticmachine @bczifra