Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Accept socks5 proxy url #174338

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jan 5, 2024

Summary

Resolve #173349
Resolve #158659

Access socks5 proxy url

UI Changes

Screenshot 2024-01-05 at 11 52 01 AM

Todo

  • test e2e that agent/fleet server accept it

@nchaulet nchaulet added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 5, 2024
@nchaulet nchaulet self-assigned this Jan 5, 2024
@nchaulet nchaulet requested a review from a team as a code owner January 5, 2024 10:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes ci:cloud-deploy Create or update a Cloud deployment labels Jan 5, 2024
@nchaulet
Copy link
Member Author

nchaulet commented Jan 5, 2024

@elasticmachine merge upstream

@jlind23
Copy link
Contributor

jlind23 commented Jan 5, 2024

@nchaulet I guess this will also resolve: #158659 right?

@nchaulet
Copy link
Member Author

nchaulet commented Jan 5, 2024

@nchaulet I guess this will also resolve: #158659 right?

Yes it will too, seems it's a duplicate issue

@nchaulet
Copy link
Member Author

nchaulet commented Jan 5, 2024

tested e2e with agents and mitmproxy in mode socks5 works well

How to test?

Run mitmproxy in socks5 mode

mitmproxy --mode socks5 --ssl-insecure

Set up a proxy in Fleet with the following url socks5://127.0.0.1:1080 and using the mitmproxy CA (by default ~/.mitmproxy/mitmproxy-ca-cert.pem) and add it to your default output

Then enroll an agent.

@nchaulet
Copy link
Member Author

nchaulet commented Jan 8, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 8, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB -39.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 158.0KB 158.1KB +84.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit d672936 into elastic:main Jan 8, 2024
27 checks passed
@nchaulet nchaulet deleted the feature-accept-socks5-proxy-url branch January 8, 2024 13:15
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 8, 2024
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.13.0
Projects
None yet
7 participants