[Lens] Duration formatter follow up #162453
Assignees
Labels
enhancement
New value added to drive a business result
Feature:Lens
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Comments
stratoula
added
enhancement
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
stratoula
added
the
impact:medium
dej611
added a commit
that referenced
this issue
Aug 2, 2023
## Summary Fix #162453 This PR address few design feedback for the formatter area and adds supports for the duration formatter within the TSDB -> Lens transition feature. List of features: * new shared component for "synced prepend" in EUI form controls `Prepend` + `PrependWidthProvider` ✨ * Integrate design feedback within the dimension editor 💄 * sync prepend width * `Human readable` -> `Friendly` relabel * add support for duration formatter for the TSVB to Lens feature * Fix formatter bug for `Count` operation 🐛 * Add tests ✅ * Add external Numeral link for Custom formatter ✨ * Revisit UI for compact switch control 💄 * `From` -> `Convert` relabel for duration formatter 💄 * Hide `Compact` and `Decimals` controls for `Friendly (approximate)` output selection <img width="331" alt="Screenshot 2023-08-01 at 10 53 46" src="https://github.com/elastic/kibana/assets/924948/42ec154d-3a9d-410d-9949-f137a86214b6"> <img width="335" alt="Screenshot 2023-08-01 at 10 53 33" src="https://github.com/elastic/kibana/assets/924948/9ffb8b12-fb01-47a8-9647-d498bb8bad86"> <img width="339" alt="Screenshot 2023-08-01 at 10 53 24" src="https://github.com/elastic/kibana/assets/924948/c6825a32-f59f-4e8e-ad6d-1a24dfafd23d"> <img width="337" alt="Screenshot 2023-08-01 at 10 53 16" src="https://github.com/elastic/kibana/assets/924948/0104aa92-03cb-47ca-ac64-aa0397c42321"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature:
As a follow up for the duration formatter in Lens we need to:
The text was updated successfully, but these errors were encountered: