Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Flaky test] [Exceptions] Fix flakiness of exception comments #162565

Closed
Tracked by #161506
WafaaNasr opened this issue Jul 26, 2023 · 3 comments
Closed
Tracked by #161506

[Security Solution] [Flaky test] [Exceptions] Fix flakiness of exception comments #162565

WafaaNasr opened this issue Jul 26, 2023 · 3 comments
Labels
failed-test A test failure on a tracked branch, potentially flaky-test flake-docs Temp label to gather PRs used to create dev docs Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team test-failure-flaky

Comments

@WafaaNasr
Copy link
Contributor

WafaaNasr commented Jul 26, 2023 •
edited
Loading

Fix the flaky test Add, copy comments in different exceptions type and validate sharing them between users Rule exceptions and Add comment on a new exception, add another comment has unicode from a different user and copy to clipboard Add comment on a new exception, add another comment has unicode from a different user and copy to clipboard

https://elastic.slack.com/archives/C04TLGXNJ3B/p1690277796706449

https://elastic.slack.com/archives/C04TLGXNJ3B/p1690331623749679
@WafaaNasr WafaaNasr added test-failure-flaky Team:Detections and Resp Security Detection Response Team Team:Detection Engine Security Solution Detection Engine Area labels Jul 26, 2023
@WafaaNasr WafaaNasr self-assigned this Jul 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@WafaaNasr WafaaNasr mentioned this issue Jul 26, 2023
Closed
@WafaaNasr
Copy link
Contributor Author

WafaaNasr commented Jul 27, 2023 •
edited
Loading

Mainly fails in the following steps:

  1. On occasions, Cypress faces difficulties in locating the Comment panel to add comments due to a multiple rendering issue affecting the Exception flyout.

  2. Navigating to Exceptions from the Rules table after logging in with the second user

image

  1. Asserting that the exception table has two exceptions because the created exception doesn't appear immediately in the
    table after the addition, as well as asserting that the comment is created successfully

image

@WafaaNasr
Copy link
Contributor Author

According to the previous results, this test seems to be quite flaky, looking into converting it to a FTR test

This was referenced Jul 31, 2023
Merged
Closed
@WafaaNasr WafaaNasr added the failed-test A test failure on a tracked branch, potentially flaky-test label Aug 1, 2023
WafaaNasr added a commit that referenced this issue Aug 1, 2023
@WafaaNasr @kibanamachine
[Security Solution] [Detection Engine] Fix exception comment flakiness (
a2275dd 
#162807)

## Summary

- Addresses #162565 
- Converting the `Comments` related Cypress test to a FTR test according
to these
[observations](#162565 (comment))

---------

Co-authored-by: kibanamachine <[email protected]>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@WafaaNasr @kibanamachine
[Security Solution] [Detection Engine] Fix exception comment flakiness (
a1ef336 
elastic#162807)

## Summary

- Addresses elastic#162565 
- Converting the `Comments` related Cypress test to a FTR test according
to these
[observations](elastic#162565 (comment))

---------

Co-authored-by: kibanamachine <[email protected]>
WafaaNasr added a commit that referenced this issue Aug 24, 2023
@WafaaNasr
[8.9] [Security Solution] [Detection Engine] Fix exception comment fl…
63985f2 
…akiness (#162807) (#164621)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] [Detection Engine] Fix exception comment
flakiness (#162807)](#162807)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Wafaa
Nasr","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-01T13:58:40Z","message":"[Security
Solution] [Detection Engine] Fix exception comment flakiness
(#162807)\n\n## Summary\r\n\r\n- Addresses
#162565 \r\n- Converting the
`Comments` related Cypress test to a FTR test according\r\nto
these\r\n[observations](https://github.com/elastic/kibana/issues/162565#issuecomment-1653410937)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a2275dd346b027db0224e7afa5df58158eb9b641","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["WIP","release_note:skip","test-failure-flaky","Team:Detection
Engine","v8.10.0","v8.9.2"],"number":162807,"url":"https://github.com/elastic/kibana/pull/162807","mergeCommit":{"message":"[Security
Solution] [Detection Engine] Fix exception comment flakiness
(#162807)\n\n## Summary\r\n\r\n- Addresses
#162565 \r\n- Converting the
`Comments` related Cypress test to a FTR test according\r\nto
these\r\n[observations](https://github.com/elastic/kibana/issues/162565#issuecomment-1653410937)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a2275dd346b027db0224e7afa5df58158eb9b641"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162807","number":162807,"mergeCommit":{"message":"[Security
Solution] [Detection Engine] Fix exception comment flakiness
(#162807)\n\n## Summary\r\n\r\n- Addresses
#162565 \r\n- Converting the
`Comments` related Cypress test to a FTR test according\r\nto
these\r\n[observations](https://github.com/elastic/kibana/issues/162565#issuecomment-1653410937)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a2275dd346b027db0224e7afa5df58158eb9b641"}},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@yctercero yctercero added the flake-docs Temp label to gather PRs used to create dev docs label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failed-test A test failure on a tracked branch, potentially flaky-test flake-docs Temp label to gather PRs used to create dev docs Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team test-failure-flaky
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yctercero @WafaaNasr @elasticmachine