-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset quality] Hide Estimated data for serverless deployments #178954
Labels
Comments
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Kerry350
added a commit
that referenced
this issue
Apr 5, 2024
## Summary Closes #178954 Circumvents fetching of the data via the state machine, hides the relevant UI section, and updates the tests to exclude estimated data. The route isn't technically disabled server side but since this is an internal route, and this is a stop gap until new APIs arrive, this should be sufficient. The `parseSummaryPanel` helper is shared between stateful and serverless tests so I tried to work around this in the least disruptive way possible (again, as this is temporary and will change). ## Stateful ![Screenshot 2024-03-21 at 13 35 55](https://github.com/elastic/kibana/assets/471693/be95987c-fc13-4004-b1ea-a8eadeeca3d0) ![Screenshot 2024-03-21 at 13 36 00](https://github.com/elastic/kibana/assets/471693/7ffd6fb4-8c54-488c-ab51-afa416cc1982) ## Serverless ![Screenshot 2024-03-21 at 13 35 19](https://github.com/elastic/kibana/assets/471693/ebe82245-9e23-40ed-a0d4-e6688bae5a0a) ![Screenshot 2024-03-21 at 13 35 25](https://github.com/elastic/kibana/assets/471693/35639fbe-9dc8-4bc7-a806-7546ec3f4dbf) --------- Co-authored-by: kibanamachine <[email protected]>
awahab07
added a commit
that referenced
this issue
Apr 24, 2024
Closes #170492 ## Summary The PR Implements the Dataset Quality Flyout summary KPIs: "Docs count", "Size", "Services", "Hosts" and "Degraded docs". |Stateful|Serverless| |:---:|:---| |<img alt="Screenshot 2024-03-26 at 19 14 34" src="https://github.com/elastic/kibana/assets/2748376/d75de56f-0916-48a6-a101-fc3d8f084f4d">|<img alt="Screenshot 2024-03-26 at 17 02 05" src="https://github.com/elastic/kibana/assets/2748376/46d58946-2ed5-4c21-b53c-be3d43e7b857">| "Show all" links for "Services" and "Hosts" metrics depend on some development in APM and Infra plugins and therefore will be implemented in a follow up issue. Note that "Size" metric is excluded on Serverless as the endpoint uses ES's `_stats` endpoint which is not available on Serverless (at the time of creation of this PR). The code contains some conditions and cases to tackle this, which should be considered as a temporary measure. All of the code related to these changes should either be removed or modified once there's a way to calculate the size of an index/dataStream on Serverless (see [related ](#178954)). The following changes are made in particular: - Size UI component on the Flyout will be hidden on Serverless - `dataset_quality/data_streams/{dataStream}/details` endpoint will return `NaN` for size on Serverless - Unit, integration and end-to-end tests on Serverless handle "sizeBytes" property accordingly
kpatticha
pushed a commit
to kpatticha/kibana
that referenced
this issue
Apr 26, 2024
Closes elastic#170492 ## Summary The PR Implements the Dataset Quality Flyout summary KPIs: "Docs count", "Size", "Services", "Hosts" and "Degraded docs". |Stateful|Serverless| |:---:|:---| |<img alt="Screenshot 2024-03-26 at 19 14 34" src="https://github.com/elastic/kibana/assets/2748376/d75de56f-0916-48a6-a101-fc3d8f084f4d">|<img alt="Screenshot 2024-03-26 at 17 02 05" src="https://github.com/elastic/kibana/assets/2748376/46d58946-2ed5-4c21-b53c-be3d43e7b857">| "Show all" links for "Services" and "Hosts" metrics depend on some development in APM and Infra plugins and therefore will be implemented in a follow up issue. Note that "Size" metric is excluded on Serverless as the endpoint uses ES's `_stats` endpoint which is not available on Serverless (at the time of creation of this PR). The code contains some conditions and cases to tackle this, which should be considered as a temporary measure. All of the code related to these changes should either be removed or modified once there's a way to calculate the size of an index/dataStream on Serverless (see [related ](elastic#178954)). The following changes are made in particular: - Size UI component on the Flyout will be hidden on Serverless - `dataset_quality/data_streams/{dataStream}/details` endpoint will return `NaN` for size on Serverless - Unit, integration and end-to-end tests on Serverless handle "sizeBytes" property accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
_stats
api is not available in serverless, so whenever we try to use dataset quality page in a serverless deployment we get the following errorWe should hide
Estimated data
section of the summary, in serverless, until a new API is deployed for serverless, allowing us to check the size of indices.✔️ Acceptance criteria
Estimated data
section is hidden for serverless deployments.Estimated data
section is shown for stateful deployments.Estimated data
section are adjusted accordingly.The text was updated successfully, but these errors were encountered: