Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Entity Analytics] Split out asset criticality routes and constants into their own files #180531

Closed
hop-dev opened this issue Apr 10, 2024 · 1 comment · Fixed by #180702
Closed
Assignees
Labels
Team:Entity Analytics Security Entity Analytics Team technical debt Improvement of the software architecture and operational architecture

Comments

@hop-dev
Copy link
Contributor

hop-dev commented Apr 10, 2024

Implement the recommended changes from #179930 (review) so that we own more code!

@hop-dev hop-dev added technical debt Improvement of the software architecture and operational architecture Team:Entity Analytics Security Entity Analytics Team labels Apr 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@hop-dev hop-dev self-assigned this Apr 12, 2024
hop-dev added a commit that referenced this issue Apr 15, 2024
…e entity analytics team (#180702)

## Summary

Closes #180531
This pull request moves entity analytics route registration and url
definition into files owned by our team.

Currently, to add a new route we require a code owners review from both
the `security-detections-response` and `security-threat-hunting` teams
unnecessarily. This is because we needed to change the following files:

- `x-pack/plugins/security_solution/common/constants.ts`
- `x-pack/plugins/security_solution/server/routes/index.ts`

As recommended by @maximpn
[here](#179930 (review))

I have also removed redundant feature flag checks for enabling risk
scoring and risk engine privileges routes, these feature flags are
enabled now.

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Entity Analytics Security Entity Analytics Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
2 participants