Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] Reactive Estimated Data Summary Panel #182873

Closed
mohamedhamed-ahmed opened this issue May 7, 2024 · 1 comment · Fixed by #183218
Closed

[Dataset quality] Reactive Estimated Data Summary Panel #182873

mohamedhamed-ahmed opened this issue May 7, 2024 · 1 comment · Fixed by #183218
Assignees
@mohamedhamed-ahmed
Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team

Comments

@mohamedhamed-ahmed
Copy link
Contributor

mohamedhamed-ahmed commented May 7, 2024 •
edited by yngrdyn
Loading

📓 Summary

After the implementation of #179172 its now time to also make the Estimated Data panel reactive to the selected timerange and filters.

image

So that the Estimated Data displayed shows an estimate of the size of datasets displayed in the table.

✔️ Acceptance criteria

  • in the last 24 hours replaced in the tooltip with this comment.
  • Estimated Data sections reacts to filter changes
  • The size column in the table should now show the size in the selected time range and not the whole size
  • The size column is hidden in serverless since the stats API is still not available on serverless ( maybe should be replaced with doc count column?)
  • e2e tests are adapted to the summary changes as well

💡 Implementation Hints

  • The Summary panel state machine is removed completely
  • The GetEstimatedData endpoint should now return total count of docs and total size in bytes per dataset
  • Once [Dataset quality] using msearch to speed up degradedDocs query #183023 is complete we will have the number of documents per dataset in the selected time range as part of the degraded docs endpoint response
  • The result from the previous 2 points can then be used to calculate the size of each dataset in the selected time range, and this can be added as part of the datasetstats object.
@mohamedhamed-ahmed mohamedhamed-ahmed added Team:obs-ux-logs Observability Logs User Experience Team Feature:Dataset Health labels May 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@mohamedhamed-ahmed mohamedhamed-ahmed mentioned this issue May 7, 2024
Closed
@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this May 9, 2024
This was referenced May 12, 2024
Merged
Closed
mohamedhamed-ahmed added a commit that referenced this issue May 14, 2024
@mohamedhamed-ahmed @kibanamachine
[Dataset Quality] Reactive Estimated Data Panel (#183218)
f33b662 
closes #182873

## 📝  Summary
After implementing #179172 its
now time to make the `Estimated Data` panel reactive to all table
filters as well.

This PR is the last step into making the summary panel reactive to all
table filters. As part of the implementation the following has been
done:

1. The summary panel state machine is completely removed as its no
longer needed and we now rely on the dataset quality state machine.
2. The Estimated Size panel is now reactive to all filters and show a
sum of the dataset sizes displayed in the table.
3. The `Size` column now shows the size for each dataset within the
given time range.
4. The `Size` column and the `Estimated data` panel are now both hidden
on `serverless` as they both rely on the `stats` API which is not yet
available on serverless.
5. As part of this ticket
#180582 we should start showing
the number of docs instead of the size on serverless.

## 🎥 Demo


https://github.com/elastic/kibana/assets/11225826/a4a4e013-e514-480c-aa4e-eb9d6ff10b82

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohamedhamed-ahmed mohamedhamed-ahmed

Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dataset Quality] Reactive Estimated Data Panel mohamedhamed-ahmed/kibana
2 participants
@mohamedhamed-ahmed @elasticmachine