Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize storage of query? #186

Closed
gladed opened this issue Jun 22, 2013 · 5 comments
Closed

Centralize storage of query? #186

gladed opened this issue Jun 22, 2013 · 5 comments

Comments

@gladed
Copy link

gladed commented Jun 22, 2013

Right now the user experience is confusing between stringquery and histogram (and other panels as well).

If you alter the stringquery, it changes the histogram (good). If you edit the histogram to have nice labels for everything, then update the stringquery again, you lose all the nice labels (bad). This kind of thing happens all the time when I'm designing dashboards and there's no way to recover the lost work.

I think this happens because internally there's no central place to store the query. Each panel tries to adapt to changes that the other panels fire off, but then stores its own private copy. So when another panel makes a change and fires a "query" message, everyone else's metadata gets blown away.

Could there be a SINGLE place to store the query array for a given group which all panels can reach?

@hraff
Copy link

hraff commented Jun 24, 2013

Hi,

If I understand your problem, You can create a new group for each group of panel which you want to modify with the same query. When you edit your panel you have to change the groupe of your panel to regroup this one with others. And you create a stringquery with this group.

@Lins59
Copy link

Lins59 commented Jun 24, 2013

Hi,

Please see the comment I made here : #163 (comment)
As hraff has mentionned, you can also put panels you want untouched un another group than the stringquery.

Regards,
Lins

@gladed
Copy link
Author

gladed commented Jun 24, 2013

I guess that's the right thing to do ... put them all in separate groups.
If I group anything with a histogram that has labels assigned to its
queries, its at risk of losing them if I change the query in any other
panels in the same group. I guess this is as-designed then?
On Jun 24, 2013 12:31 AM, "hraff" [email protected] wrote:

Hi,

If I understand your problem, You can create a new group for each group of
panel which you want to modify with the same query. When you edit your
panel you have to change the groupe of your panel to regroup this one with
others. And you create a stringquery with this group.


Reply to this email directly or view it on GitHubhttps://github.com//issues/186#issuecomment-19892710
.

@rashidkpc
Copy link
Contributor

Currently designed this way. Working on a refactor that should address this

@rashidkpc
Copy link
Contributor

milestone pre3 has a query service that coordinates all of the queries on the dashboard

spalger pushed a commit to spalger/kibana that referenced this issue Mar 3, 2016
…anel

The cluster panel's status now has an info icon to explain non-green state
The indices stats table now takes index status into consideratio when choosing what indices to show.
Indices stats table also sorts indices names with a .prefix  lower then normal names.

Closes elastic#143, Closes elastic#186, Relates to elastic#181
harper-carroll pushed a commit to harper-carroll/kibana that referenced this issue Jul 11, 2016
w33ble added a commit to w33ble/kibana that referenced this issue Sep 13, 2018
* fix: bug where element render functions could mutate redux state

* fix: allow grid to work without an x dimension

* chore: hoise getColor out of grid render fn

there's no need to keep re-defining that function, it never changes, it simply needs the pallette value passed in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants