Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Use summary column service component for service column #196541

Closed
mohamedhamed-ahmed opened this issue Oct 16, 2024 · 10 comments · Fixed by #196742
Closed

[Discover] Use summary column service component for service column #196541

mohamedhamed-ahmed opened this issue Oct 16, 2024 · 10 comments · Fixed by #196742
Assignees
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:obs-ux-logs Observability Logs User Experience Team

Comments

@mohamedhamed-ahmed
Copy link
Contributor

mohamedhamed-ahmed commented Oct 16, 2024

📝 Summary

A new cell renderer for the service.name field was introduced here. As an enhancement we would like to have the cell renderer display the same component as the one used in the summary column for the service.name field, including the APM link and quick filters.

Image

✔️ Acceptance Criteria

  • Service name column now displays the same component used in the summary column for the service name field
  • Quick filters are displayed
  • Service name link is displayed
  • The service name link is disabled when APM is disabled

💡 Implementation hints

❓ Open Question

  • Do we need to keep the Pill shape in the service name column or not?
@mohamedhamed-ahmed mohamedhamed-ahmed added enhancement New value added to drive a business result Team:obs-ux-logs Observability Logs User Experience Team labels Oct 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this Oct 16, 2024
@mohamedhamed-ahmed mohamedhamed-ahmed added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mohamedhamed-ahmed
Copy link
Contributor Author

@LucaWintergerst @gbamparop are we targetting this for 8.16 ?

Screen.Recording.2024-10-17.at.14.38.59.mov

This is how it will look like after the change, @patpscal @LucaWintergerst wdyt?

@flash1293
Copy link
Contributor

Feature freeze for 8.16 already passed, and I would argue that this is a new feature.

@yngrdyn
Copy link
Contributor

yngrdyn commented Oct 17, 2024

What if we ditch the pill shape? The pill shape is useful in summary column because we have multiple information there and allows users to filter by specific parts inside the column (e.g. host.name, cloud.instance.id, etc)

@patpscal
Copy link

patpscal commented Oct 17, 2024

Do we need to keep the Pill shape in the service name column or not?

The added functionality of the pill (quick filter in/out) is already solved at a cell level in the service name column, regardless of the content, so that's not adding value.

But there's value in always seeing this parameter displayed in the same way (pill with logo + label), which can help users identify it quickly. Because of this, I would be inclined to keep it as a pill (and maybe remove the on-click behavior of the pill to avoid redundancy with the cell actions), but I don't have a strong opinion.

@mohamedhamed-ahmed
Copy link
Contributor Author

@yngrdyn I also have mixed opinions there, at the same time it gives kind of an indication that there are more actions when clicked.

@mohamedhamed-ahmed
Copy link
Contributor Author

mohamedhamed-ahmed commented Oct 17, 2024

and maybe remove the on-click behavior of the pill to avoid redundancy with the cell actions

@patpscal we need the click action for the service name link to navigate there. It is recorded in the demo video at the very end

@mohamedhamed-ahmed
Copy link
Contributor Author

I am also be a bit more inclined towards keeping the pill shape, or we could also maybe make the service.name itself clickable without the need for the pill shape or the popover with the filters 🤔

@patpscal
Copy link

Sorry @mohamedhamed-ahmed, I see what you mean now! Then the more reasons IMO to keep the shape

@davismcphee davismcphee added the Project:OneDiscover Enrich Discover with contextual awareness label Oct 17, 2024
mohamedhamed-ahmed added a commit that referenced this issue Oct 22, 2024
#196742)

closes #196541
## 📝  Summary

This PR updated the `service.name` cell renderer so that it mimics what
we have in the `summary` column.
It now shows a clickable pill shape for quick filters and navigating to
the service page if `APM` is available.

## 🎥 Demo


https://github.com/user-attachments/assets/627b39af-f008-487b-82f2-c0ab79aff9a4
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 22, 2024
elastic#196742)

closes elastic#196541
## 📝  Summary

This PR updated the `service.name` cell renderer so that it mimics what
we have in the `summary` column.
It now shows a clickable pill shape for quick filters and navigating to
the service page if `APM` is available.

## 🎥 Demo

https://github.com/user-attachments/assets/627b39af-f008-487b-82f2-c0ab79aff9a4
(cherry picked from commit 3130492)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants