-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Use summary column service component for service column #196541
Comments
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@LucaWintergerst @gbamparop are we targetting this for 8.16 ? Screen.Recording.2024-10-17.at.14.38.59.movThis is how it will look like after the change, @patpscal @LucaWintergerst wdyt? |
Feature freeze for 8.16 already passed, and I would argue that this is a new feature. |
What if we ditch the pill shape? The pill shape is useful in summary column because we have multiple information there and allows users to filter by specific parts inside the column (e.g. |
The added functionality of the pill (quick filter in/out) is already solved at a cell level in the service name column, regardless of the content, so that's not adding value. But there's value in always seeing this parameter displayed in the same way (pill with logo + label), which can help users identify it quickly. Because of this, I would be inclined to keep it as a pill (and maybe remove the on-click behavior of the pill to avoid redundancy with the cell actions), but I don't have a strong opinion. |
@yngrdyn I also have mixed opinions there, at the same time it gives kind of an indication that there are more actions when clicked. |
@patpscal we need the click action for the service name link to navigate there. It is recorded in the demo video at the very end |
I am also be a bit more inclined towards keeping the pill shape, or we could also maybe make the |
Sorry @mohamedhamed-ahmed, I see what you mean now! Then the more reasons IMO to keep the shape |
#196742) closes #196541 ## 📝 Summary This PR updated the `service.name` cell renderer so that it mimics what we have in the `summary` column. It now shows a clickable pill shape for quick filters and navigating to the service page if `APM` is available. ## 🎥 Demo https://github.com/user-attachments/assets/627b39af-f008-487b-82f2-c0ab79aff9a4
elastic#196742) closes elastic#196541 ## 📝 Summary This PR updated the `service.name` cell renderer so that it mimics what we have in the `summary` column. It now shows a clickable pill shape for quick filters and navigating to the service page if `APM` is available. ## 🎥 Demo https://github.com/user-attachments/assets/627b39af-f008-487b-82f2-c0ab79aff9a4 (cherry picked from commit 3130492)
📝 Summary
A new cell renderer for the
service.name
field was introduced here. As an enhancement we would like to have the cell renderer display the same component as the one used in the summary column for theservice.name
field, including the APM link and quick filters.✔️ Acceptance Criteria
💡 Implementation hints
❓ Open Question
The text was updated successfully, but these errors were encountered: