Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Deprecate legacy/unused configurations #200898

Closed
tonyghiani opened this issue Nov 20, 2024 · 1 comment · Fixed by #201625
Closed

[Logs UI] Deprecate legacy/unused configurations #200898

tonyghiani opened this issue Nov 20, 2024 · 1 comment · Fixed by #201625
Assignees
@tonyghiani
Labels
Team:obs-ux-logs Observability Logs User Experience Team

Comments

@tonyghiani
Copy link
Contributor

tonyghiani commented Nov 20, 2024 •
edited
Loading

📓 Summary

As part of the readiness for the v9.0.0 upgrade, some unused configurations will be deprecated to discourage their usage as they'll be not used by removed features.

For each deprecation, leverage the config deprecations factory to gracefully handle and surface config deprecations to end users in the Upgrade Assistant.

Example of config deprecations factory usage

✔ Acceptance criteria

  • xpack.infra.sources.default.fields.message should be deprecated and removed from the set configurations (use the addDeprecation command like in the example)
    • Add a release note: instructions, please see this example of a release note so that this change can be linked to/surfaced in our docs.
  • xpack.observabilityLogsExplorer.navigation.showAppLink can be deprecated as internally unused, accordingly updating the implementation (use the unused command like in the example).
  • xpack.observabilityOnboarding.ui.enabled can be deprecated as internally unused, accordingly updating the implementation (use the unused command like in the example)
  • xpack.observabilityOnboarding.serverless.enabled can be deprecated as internally unused, accordingly updating the implementation (use the unused command like in the example)
@tonyghiani tonyghiani added the Team:obs-ux-logs Observability Logs User Experience Team label Nov 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@tonyghiani tonyghiani mentioned this issue Nov 25, 2024
Merged
@tonyghiani tonyghiani self-assigned this Nov 27, 2024
tonyghiani added a commit that referenced this issue Dec 5, 2024
@tonyghiani @kibanamachine
[Logs] Deprecate configuration settings (#201625)
2994b00 
## 📓 Summary

Closes #200898 

These changes deprecate some unused configurations and update the
implementation where required in preparation for the Kibana v9 upgrade.

<img width="3004" alt="Screenshot 2024-11-25 at 12 54 14"
src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
tonyghiani added a commit to tonyghiani/kibana that referenced this issue Dec 5, 2024
@tonyghiani
[Logs] Deprecate configuration settings (elastic#201625)
c0e64ed 
## 📓 Summary

Closes elastic#200898

These changes deprecate some unused configurations and update the
implementation where required in preparation for the Kibana v9 upgrade.

<img width="3004" alt="Screenshot 2024-11-25 at 12 54 14"
src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 2994b00)

# Conflicts:
#	x-pack/plugins/observability_solution/infra/tsconfig.json
tonyghiani added a commit that referenced this issue Dec 5, 2024
@tonyghiani @kibanamachine
[8.x] [Logs] Deprecate configuration settings (#201625) (#203063)
e60bca6 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Logs] Deprecate configuration settings
(#201625)](#201625)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T09:23:54Z","message":"[Logs]
Deprecate configuration settings (#201625)\n\n## 📓 Summary\r\n\r\nCloses
#200898 \r\n\r\nThese changes deprecate some unused configurations and
update the\r\nimplementation where required in preparation for the
Kibana v9 upgrade.\r\n\r\n<img width=\"3004\" alt=\"Screenshot
2024-11-25 at 12 54
14\"\r\nsrc=\"https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Antonio Ghiani <[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"2994b0001cbae6bc1528bc1ad77c435597e0d5a2","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:deprecation","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"number":201625,"url":"https://github.com/elastic/kibana/pull/201625","mergeCommit":{"message":"[Logs]
Deprecate configuration settings (#201625)\n\n## 📓 Summary\r\n\r\nCloses
#200898 \r\n\r\nThese changes deprecate some unused configurations and
update the\r\nimplementation where required in preparation for the
Kibana v9 upgrade.\r\n\r\n<img width=\"3004\" alt=\"Screenshot
2024-11-25 at 12 54
14\"\r\nsrc=\"https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Antonio Ghiani <[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"2994b0001cbae6bc1528bc1ad77c435597e0d5a2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201625","number":201625,"mergeCommit":{"message":"[Logs]
Deprecate configuration settings (#201625)\n\n## 📓 Summary\r\n\r\nCloses
#200898 \r\n\r\nThese changes deprecate some unused configurations and
update the\r\nimplementation where required in preparation for the
Kibana v9 upgrade.\r\n\r\n<img width=\"3004\" alt=\"Screenshot
2024-11-25 at 12 54
14\"\r\nsrc=\"https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Antonio Ghiani <[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"2994b0001cbae6bc1528bc1ad77c435597e0d5a2"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
@tonyghiani @kibanamachine @SoniaSanzV
[Logs] Deprecate configuration settings (elastic#201625)
54ab991 
## 📓 Summary

Closes elastic#200898 

These changes deprecate some unused configurations and update the
implementation where required in preparation for the Kibana v9 upgrade.

<img width="3004" alt="Screenshot 2024-11-25 at 12 54 14"
src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
@tonyghiani @kibanamachine @SoniaSanzV
[Logs] Deprecate configuration settings (elastic#201625)
ed61270 
## 📓 Summary

Closes elastic#200898 

These changes deprecate some unused configurations and update the
implementation where required in preparation for the Kibana v9 upgrade.

<img width="3004" alt="Screenshot 2024-11-25 at 12 54 14"
src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
@tonyghiani @kibanamachine @CAWilson94
[Logs] Deprecate configuration settings (elastic#201625)
3bbae20 
## 📓 Summary

Closes elastic#200898 

These changes deprecate some unused configurations and update the
implementation where required in preparation for the Kibana v9 upgrade.

<img width="3004" alt="Screenshot 2024-11-25 at 12 54 14"
src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this issue Dec 10, 2024
@tonyghiani @kibanamachine @Samiul-TheSoccerFan
[Logs] Deprecate configuration settings (elastic#201625)
ba808f7 
## 📓 Summary

Closes elastic#200898 

These changes deprecate some unused configurations and update the
implementation where required in preparation for the Kibana v9 upgrade.

<img width="3004" alt="Screenshot 2024-11-25 at 12 54 14"
src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this issue Dec 11, 2024
@tonyghiani @kibanamachine @mykolaharmash
[Logs] Deprecate configuration settings (elastic#201625)
b0d39ed 
## 📓 Summary

Closes elastic#200898 

These changes deprecate some unused configurations and update the
implementation where required in preparation for the Kibana v9 upgrade.

<img width="3004" alt="Screenshot 2024-11-25 at 12 54 14"
src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@tonyghiani @kibanamachine @CAWilson94
[Logs] Deprecate configuration settings (elastic#201625)
77194cf 
## 📓 Summary

Closes elastic#200898 

These changes deprecate some unused configurations and update the
implementation where required in preparation for the Kibana v9 upgrade.

<img width="3004" alt="Screenshot 2024-11-25 at 12 54 14"
src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyghiani tonyghiani

Labels
Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs] Deprecate configuration settings tonyghiani/kibana
2 participants
@elasticmachine @tonyghiani