Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UA] Remove panel that links to logs explorer #201532

Closed
jloleysens opened this issue Nov 25, 2024 · 5 comments · Fixed by #203833
Closed

[UA] Remove panel that links to logs explorer #201532

jloleysens opened this issue Nov 25, 2024 · 5 comments · Fixed by #203833
Assignees
Labels
chore Feature:Upgrade Assistant Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jloleysens
Copy link
Contributor

jloleysens commented Nov 25, 2024

In the upgrade assistant, we guide users to Elasticsearch's deprecation logs to help them address their usage of deprecated APIs. Today we guide them to "Logs Exploerer" and "Discover". We should only guide them to "Discover", i.e. remove the panel about "Logs explorer" entirely.

This is what the panel looks like today:

Image

This is what it should look like, possibly without the surrounding panel

Image

@jloleysens jloleysens added chore Feature:Upgrade Assistant Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Nov 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@jovana-andjelkovic
Copy link

Can we maybe change the width to hug the text rather than fit the width? So we keep the sentence in 1 line, but avoid extra white space on the right?

@TinaHeiligers
Copy link
Contributor

tentatively self assigning

@TinaHeiligers TinaHeiligers self-assigned this Dec 4, 2024
@TinaHeiligers
Copy link
Contributor

@afharo wants @jesuswr to take this as a good first react issue 😄 I'll guide him along the way.

@TinaHeiligers TinaHeiligers removed their assignment Dec 11, 2024
jesuswr added a commit to jesuswr/kibana that referenced this issue Dec 12, 2024
## Summary

resolves elastic#201532

Removed the panel containing the logs explorer link. Updated tests and
i18n.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit b059879)

# Conflicts:
#	x-pack/platform/plugins/private/translations/translations/zh-CN.json
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
## Summary

resolves elastic#201532

Removed the panel containing the logs explorer link. Updated tests and
i18n.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Upgrade Assistant Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
5 participants